Repository navigation
feat(manifest): ask for the reachability settings in the setup wizards - #1729
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Conversation
08f14b1 to
bc39c00
Compare
bc39c00 to
78fadc7
Compare
PR SummaryLow Risk Overview The wizards ask whether to compile before reachability ( Invalid or tool-incompatible Changelog and broad unit/integration tests cover inheritance, overrides, validation, and write behavior. Reviewed by Cursor Bugbot for commit 78fadc7. Configure here. |
78fadc7 to
14db272
Compare
14db272 to
8e07fbd
Compare
8e07fbd to
f245568
Compare
f245568 to
d957ff9
Compare
d957ff9 to
94245fc
Compare
`socket manifest setup` and `socket manifest setup --dynamic-sbom-inference` ask, for each build tool that generates facts: - whether to build the project before reachability analysis. A no writes "none" only to override an inherited "compile", and otherwise leaves the setting unset; - Maven, Gradle and sbt: whether to use a different JDK for the analysis, showing the one in effect, inherited or not; - .NET: whether to start a framework-dependent build's analysis on a given runtime, taking major.minor or major.minor.patch[-prerelease]. The wizards read socket.json as written, so they run under an invalid reachability value: they warn about what a build tool cannot take and replace it with the answers, and ignore an invalid inherited value for their defaults.
94245fc to
244ddca
Compare
Heads up, reviewer
Update wizard to configure reachability settings 🧙♂️
LLM Description written by Claude Code:claude-opus-5-5
socket manifest setupandsocket manifest setup --dynamic-sbom-inferenceask for #1728'sreachabilitysettings for each build tool that generates Socket facts, so they can be set without editing socket.json by hand.Merges with the stack; the release gates and the expected e2e failures are in #1725.
Questions
"none"only to override an inherited"compile".reachabilityvalue is invalid: they warn about one in the socket.json they write and replace it with the answers.Stack
Changelog
In
CHANGELOG.mdunder[Unreleased]:Added
socket manifest setupandsocket manifest setup --dynamic-sbom-inferenceask for the reachability settings, so there is no need to editsocket.jsonby hand.🤖 Generated with Claude Code