Skip to content

refactor(manifest): delete socket-cli's build-tool scripts and facts assembly - #1727

Open
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
jfblaa/facts-2-generate-factsfrom
jfblaa/facts-3-delete-scripts
Open

Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
jfblaa/facts-2-generate-factsfrom
jfblaa/facts-3-delete-scripts

Conversation

@jfblaa

@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Heads up, reviewer

Removing build scripts from Socket CLI.


LLM Description written by Claude Code:claude-opus-5-5

Deletion only: Coana generates Socket facts as of #1726, so socket-cli's Gradle init scripts, sbt plugins, Maven extension and .NET tool go, with the records parser, facts assembler, their compat suites, fixtures, CI jobs and packaging steps. Users see no change beyond #1726's, apart from a smaller package.

Merges with the stack; the release gates and the expected e2e failures are in #1725.

This removes the repository's last C#, so CodeQL's Analyze (csharp) check (default setup) fails with "No source files found" until C# is removed from the languages in the repository's code scanning settings.

Stack
  1. fix: keep the API token and settings socket-cli passes Coana out of the build tools it runs #1725: Keep the Socket API token out of the tools Coana runs
  2. feat(manifest): generate Socket facts with Coana #1726: Generate Socket facts with Coana
  3. refactor(manifest): delete socket-cli's build-tool scripts and facts assembly #1727: Delete socket-cli's build-tool scripts and facts assembly (internal) (this PR)
  4. feat(manifest): add socket.json reachability settings for the build tools #1728: socket.json reachability settings for the build tools
  5. feat(manifest): ask for the reachability settings in the setup wizards #1729: Reachability settings in the setup wizards
  6. refactor: follow-ups to generating Socket facts with Coana #1733: Follow-ups (draft)

Changelog

No entry: internal.

🤖 Generated with Claude Code

@cursor

cursor Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Large deletion of manifest resolution paths; behavior depends on Coana integration from the stack being complete in all release variants.

Overview
Removes socket-cli’s entire in-tree manifest build-tool stack—Gradle/sbt init scripts, Maven extension, .NET socket-facts-dotnet tool, records parsing, assembleFacts, sidecar/resolution-report plumbing, compat fixtures, and related unit tests—now that facts generation is delegated to Coana (per the stacked PRs).

Build and release no longer compile or copy those assets: copyManifestScripts and INLINED_SOCKET_CLI_PUBLISHED_BUILD jar/dotnet gates are gone from the rollup dist build; package.json drops build:dotnet-tool / build:maven-extension; publish and package-matrix jobs stop pre-building those artifacts; CI drops the .NET SDK check. .gitignore and socket.yml shed hundreds of un-ignore paths for the deleted trees.

build-tool.mts is trimmed (e.g. socketFactsFileName, NAMESPACELESS_PURL_TYPES) but kept for CLI build-root/bin resolution used by run-manifest-facts.mts.

Reviewed by Cursor Bugbot for commit c830b3c. Configure here.

Coana generates Socket facts now, so socket-cli's own machinery for it
goes: the Gradle init scripts, the sbt plugins, the Maven extension, the
.NET tool, the records parser, the facts assembler and sidecar, the
exclude-path glob compiler, the resolution report renderer, the compat
suites, and the steps that built and bundled them for npm, the package
matrix, CI and the standalone build.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant