Repository navigation
feat(manifest): generate Socket facts with Coana - #1726
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Conversation
34c53a1 to
2429c74
Compare
PR SummaryHigh Risk Overview Facts placement and fix/reach sidecars change materially. Builds write into a caller-owned work dir; kept runs are copied to their target paths via Recursive manifest walk behavior is tightened: project membership uses absolute Reviewed by Cursor Bugbot for commit c681bbc. Configure here. |
2429c74 to
c681bbc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c681bbc. Configure here.
| factsPath: result.factsPath, | ||
| projects: result.projects, | ||
| sidecarEntry: result.sidecarEntry, | ||
| targetPath: result.targetPath, |
There was a problem hiding this comment.
Facts file not verified after Coana
Medium Severity
runManifestFacts treats Coana status: 'generated' as success without checking that factsPath exists. This command used to write the facts file itself; now Coana may exit 0 without producing it. keepFacts then copyFiles a missing path and throws, so the walk dies instead of failing closed with a clear error.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c681bbc. Configure here.
There was a problem hiding this comment.
[agent] Not changing: Coana writes the facts file before it reports generated (generateRootFacts in coana-tech/coana-package-manager#2778, generate.ts#L281-L283), and minimumVersion keeps socket-cli on a Coana that does. A missing file would be a Coana bug, not a build outcome, so socket-cli doesn't check for it again.
| // project, OOM, plugin error), not an unresolved dependency, so it fails | ||
| // regardless of `ignoreUnresolved` — that flag only tolerates dependencies a | ||
| // successful run couldn't resolve. | ||
| return result.status === 'listed' ? result.projects : undefined |
There was a problem hiding this comment.
Empty project listing treated as success
Medium Severity
listBuildProjects accepts status: 'listed' with an empty projects array. The old enumerator treated zero records as “the task never ran,” because every real Gradle, Maven, or sbt build reports at least its root. A skipped build that listed nothing now looks loaded, so its modules are not skipped with it.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c681bbc. Configure here.
There was a problem hiding this comment.
[agent] Not changing: the zero-projects rule moved into Coana with the enumerator. listRootProjects (coana-tech/coana-package-manager#2778, generate.ts#L160-L166) returns failed when the build reports no projects or no root, so listed always has at least the root and socket-cli doesn't check it twice.
| dir: path.join(manifestTmpDir, 'socket-facts-work'), | ||
| entries: new Map(), | ||
| withFiles: true, | ||
| } |
There was a problem hiding this comment.
Work directory never created before Coana
Medium Severity
socket scan create --reach and socket fix pass Coana a --work-dir that is never created. socket scan reach uses withTmpDir so the directory exists. If Coana requires that path the way it requires the --output-file parent, facts generation fails only on those two commands.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c681bbc. Configure here.
There was a problem hiding this comment.
[agent] Not changing: Coana creates it. generate-socket-facts makes each build's state dir under --work-dir with mkdir(stateDir, { recursive: true }) (coana-tech/coana-package-manager#2778, cli-generate-socket-facts.ts#L94-L95), which creates the work dir too. Unlike --output-file, whose parent Coana does not create, nothing needs it to exist beforehand.
137b184 to
aa44bb9
Compare
858ae3f to
dee38ba
Compare
dee38ba to
b8e363a
Compare
socket-cli now asks `coana generate-socket-facts` for each build root instead of running its own build-tool scripts, and lists a build's projects and a .NET solution's members through the same command. - Coana writes a root's facts into its state dir under --work-dir and names where they belong. The walk always generates into a work dir, its own when no later Coana run reads one, and copies the facts of the roots it keeps to their target at the end; a dropped run never touches the file there. This replaces the save/restore of predicted facts files. - The kept roots' sidecar entries go to reachability and socket fix as --socket-facts-sidecar. - --auto-manifest builds through the same settings as the walk. Maven builds pom.xml by name, so its facts and state stay apart from a Gradle build in the same directory, and a --file in mavenOpts becomes the POM it builds instead of a build option. - A --reach-version or --fix-version older than the pinned Coana fails facts generation with a message naming that version. - The standalone build's README says every Coana use needs SOCKET_CLI_COANA_LOCAL_PATH.
b8e363a to
72f50fd
Compare


Heads up, reviewer
This PR changes socket facts SBOM generation to use coana.
LLM Description written by Claude Code:claude-opus-5-5
Socket facts for Gradle, Maven, sbt and .NET builds are generated by Coana's
generate-socket-facts, one run per build root, instead of socket-cli's own build-tool scripts (deleted in #1727). With--dynamic-sbom-inference, reachability andsocket fixthen read the state each root's run kept, so reachability analyses each JVM project on the classpath its build resolved.Merges with the stack; the release gates and the expected e2e failures are in #1725.
What changes for users
socket manifest gradle|kotlin|scala|maven|dotnet,manifest auto,--auto-manifest,--dynamic-sbom-inferenceand its setup wizard go through Coana, so they download it (network access and a Socket API token) unlessSOCKET_CLI_COANA_LOCAL_PATHnames one; the standalone build always needs that variable.--reach-versionand--fix-versionalso select the Coana that generates facts, which must be the pinned version or newer.--ignore-unresolvedno longer lets through a build whose resolution didn't run, or a failure that names no project.socket fixresolves each changed build again with the settings it was generated with, and restores its files when an upgrade didn't take.--dynamic-sbom-inferencebuilds each POM by its own file, so it ignores a--fileinmavenOpts, with a warning.Implementation
runManifestFactssends Coana one request per build root, with the hints its failure report names remedies from.--socket-facts-sidecar.Stack
Changelog
In
CHANGELOG.mdunder[Unreleased]:Added
Changed
SOCKET_CLI_COANA_LOCAL_PATH.--reach-versionand--fix-versionalso select the Coana that generates Socket facts, which must be the pinned version or newer.--dynamic-sbom-inference, reachability analyzes each JVM project on the classpath its build resolved, andsocket fixrestores a build's files when an upgrade does not take.--ignore-unresolvedno longer lets through a build whose resolution did not run, or a failure that names no project.--dynamic-sbom-inferencebuilds each POM by its own file, so it ignores a--fileinmavenOpts, with a warning.🤖 Generated with Claude Code