Skip to content

fix lifecycle rule filter conditions in bucket details - #482

Open
Bohreromir wants to merge 2 commits into
mainfrom
worktree-fix-lifecycle-filter
Open

Bohreromir wants to merge 2 commits into
mainfrom
worktree-fix-lifecycle-filter

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description

The bucket details modal checked the S3 lifecycle filter for lowercase prefix and and keys, but the AWS SDK filter uses capitalised keys.

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

The bucket details modal checked the S3 lifecycle filter for lowercase
`prefix` and `and` keys, but the AWS SDK filter uses capitalised keys,
so every non-empty filter was rendered as raw JSON.

Map the SDK filter server-side into a typed `LifecycleFilter` (prefix,
tags, object size bounds), merging single-condition and `And` filters
and honouring the deprecated rule-level `Prefix`. The modal renders one
label per condition.
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.6% 9295 / 13748
🔵 Statements 66.52% 12474 / 18752
🔵 Functions 68.32% 2989 / 4375
🔵 Branches 57.65% 5258 / 9119
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/storage/modals/details/BucketDetails.svelte 0.29% 0% 0% 0.65% 87-93
src/lib/server/storage/s3-provider.ts 97.73% 82.96% 95.52% 98.36% 336-337, 368, 477, 545-561
src/lib/storage/details-types.ts 0% 0% 0% 0%
Generated in workflow #1327 for commit e5602ad by the Vitest Coverage Report Action

@Bohreromir Bohreromir changed the title fix(storage): Show lifecycle rule filter conditions in bucket details fix lifecycle rule filter conditions in bucket details Nov 18, 2026
@Bohreromir Bohreromir self-assigned this Nov 18, 2026
@Bohreromir Bohreromir mentioned this pull request Nov 18, 2026
2 of 6 tasks
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 18, 2026
Svelte trims whitespace at each iteration's edges, so combined conditions
rendered as "Prefix: tmp/and Tag: ...". Also drop a no-op undefined spread
from the filter mapping test.
@Bohreromir
Bohreromir force-pushed the worktree-fix-lifecycle-filter branch from 3e3d6c3 to e5602ad Compare November 18, 2026 13:48
@Bohreromir
Bohreromir marked this pull request as ready for review November 18, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

1 participant