Repository navigation
fix lifecycle rule filter conditions in bucket details - #482
Open
Bohreromir wants to merge 2 commits into
Open
Bohreromir wants to merge 2 commits into
Bohreromir wants to merge 2 commits into
Conversation
The bucket details modal checked the S3 lifecycle filter for lowercase `prefix` and `and` keys, but the AWS SDK filter uses capitalised keys, so every non-empty filter was rendered as raw JSON. Map the SDK filter server-side into a typed `LifecycleFilter` (prefix, tags, object size bounds), merging single-condition and `And` filters and honouring the deprecated rule-level `Prefix`. The modal renders one label per condition.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
2 of 6 tasks
Svelte trims whitespace at each iteration's edges, so combined conditions rendered as "Prefix: tmp/and Tag: ...". Also drop a no-op undefined spread from the filter mapping test.
Bohreromir
force-pushed
the
worktree-fix-lifecycle-filter
branch
from
November 18, 2026 13:48
3e3d6c3 to
e5602ad
Compare
Bohreromir
marked this pull request as ready for review
November 18, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bucket details modal checked the S3 lifecycle filter for lowercase
prefixandandkeys, but the AWS SDK filter uses capitalised keys.Docs
Release note
Checklist
Author
Reviewer
Acceptance