Repository navigation
Enable typed linting and smaller fixes - #481
Open
Bohreromir wants to merge 5 commits into
Open
Bohreromir wants to merge 5 commits into
Bohreromir wants to merge 5 commits into
Conversation
Found by @typescript-eslint/no-unnecessary-type-assertion, mostly autofixed. Widening assertions inside vi.hoisted() and default parameters, which the rule misreports, are replaced by type annotations. Part of #411.
Since SvelteKit 2 both throw by themselves and return never, so the extra throw is redundant and trips @typescript-eslint/only-throw-error. AGENTS.md is updated to match. Part of #411.
Found by no-floating-promises, no-misused-promises and await-thenable: - Await page.route() in the Trino connection form E2E tests, so routes are registered before the page navigates or submits. - Show the "copied" state in the delete connection modal only after the clipboard write succeeded. - Use expect.element() for locator assertions in the CSV preview tests, so they retry. - Mark fire-and-forget calls whose targets handle their own errors with void, and catch the best-effort Trino tab cleanup request. - Drop await on synchronous values (Vitest browser locators, plain values in E2E assertions). Part of #411.
Found by no-base-to-string and related type-aware rules. Trino results and the CSV/Parquet previews now use a shared formatCell() helper. Also makes the remaining implicit string conversions explicit and binds window.fetch before wrapping it. Part of #411.
Type-aware linting now covers src/ and e2e/ (new e2e/tsconfig.json) and the root config files. The no-unsafe-* rules and require-await stay off: their ~1,200 hits are mostly untyped JSON, test mocks and style. Closes #411.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most changes are fairly mechanical. Looking at this on a per-commit basis might help.
Enables typed recommended ESLint linting
Also lint the e2e tests now
Some smaller bug fixes along the way.
Deliberately left out rules:
res.json()andJSON.parse, which returnany.The bucket lifecycle bug Claude will nag you about is in here: #482
Closes #411
Docs
Release note
Checklist
Author
Reviewer
Acceptance