Skip to content

Enable typed linting and smaller fixes - #481

Open
Bohreromir wants to merge 5 commits into
mainfrom
worktree-chore-411-typed-linting
Open

Bohreromir wants to merge 5 commits into
mainfrom
worktree-chore-411-typed-linting

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description

Most changes are fairly mechanical. Looking at this on a per-commit basis might help.

Enables typed recommended ESLint linting
Also lint the e2e tests now
Some smaller bug fixes along the way.

Deliberately left out rules:

  • no-unsafe- family*
  • require-await
    • Most seem to be deliberate.
  • unbound-method, no-misused-promises, checksVoidReturn.arguments
    • Only in test files.

The bucket lifecycle bug Claude will nag you about is in here: #482

Closes #411

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

Found by @typescript-eslint/no-unnecessary-type-assertion, mostly autofixed.
Widening assertions inside vi.hoisted() and default parameters, which the
rule misreports, are replaced by type annotations.

Part of #411.
Since SvelteKit 2 both throw by themselves and return never, so the extra
throw is redundant and trips @typescript-eslint/only-throw-error. AGENTS.md
is updated to match.

Part of #411.
Found by no-floating-promises, no-misused-promises and await-thenable:

- Await page.route() in the Trino connection form E2E tests, so routes are
  registered before the page navigates or submits.
- Show the "copied" state in the delete connection modal only after the
  clipboard write succeeded.
- Use expect.element() for locator assertions in the CSV preview tests, so
  they retry.
- Mark fire-and-forget calls whose targets handle their own errors with
  void, and catch the best-effort Trino tab cleanup request.
- Drop await on synchronous values (Vitest browser locators, plain values
  in E2E assertions).

Part of #411.
Found by no-base-to-string and related type-aware rules. Trino results and
the CSV/Parquet previews now use a shared formatCell() helper. Also makes
the remaining implicit string conversions explicit and binds window.fetch
before wrapping it.

Part of #411.
Type-aware linting now covers src/ and e2e/ (new e2e/tsconfig.json) and the
root config files. The no-unsafe-* rules and require-await stay off: their
~1,200 hits are mostly untyped JSON, test mocks and style.

Closes #411.
@github-actions

Copy link
Copy Markdown

⚠️ Coverage report too large to inline, see the workflow summary.

@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 18, 2026
@Bohreromir
Bohreromir marked this pull request as ready for review November 18, 2026 13:50
@Bohreromir Bohreromir self-assigned this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

Enable typed linting (typescript-eslint recommendedTypeChecked)

1 participant