Repository navigation
Use upstream drivers for Waveshare DSI panels - #7782
Open
popcornmix wants to merge 6 commits into
Open
popcornmix wants to merge 6 commits into
popcornmix wants to merge 6 commits into
Conversation
panel-waveshare-dsi-v2: Drop the panels now handled by upstream drivers (jadard-jd9365da-h3, himax-hx8394, himax-hx83102, focaltech-ota7290b and ilitek-ili9881c). Upstream picks the lane count from DT, so the -4lane variants go too. The Waveshare controller is now driven by the upstream gpio-waveshare-dsi driver, with avdd and iovcc as fixed regulators, so take those as supplies rather than GPIOs. Use reset-gpios with the active-low convention of the upstream panel drivers, as the panel node is shared. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
panel-waveshare-dsi: Drop the panels handled upstream by the waveshare,dsi2dpi/dsi2lvds bridge and panel-simple. Keep 6.25inch-b, 10.1inch-e (2 and 4 lane) and 13.3inch 2 lane, which upstream lacks. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
…hare 5.0" A The Waveshare driver for the 5.0" A panel waits 200ms after leaving sleep, writes SETDISP again with its full 12 byte payload, turns the display on and then waits a further 80ms. Allow a panel to supply its own display-on sequence, and use the vendor one for this panel. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Enable the Waveshare DSI TOUCH GPIO controller, the Waveshare DSI bridge and the jadard-jd9365da-h3, himax-hx8394, himax-hx83102 and focaltech-ota7290b panels, and drop the downstream Waveshare regulator. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
vc4-kms-dsi-waveshare-panel-v2: drive the panel controller with the upstream gpio-waveshare-dsi driver, with fixed regulators for VCC, IOVCC and AVDD, and give the panel node the supplies and GPIOs that the upstream panel drivers look up. The 4 lane variants now select the lane count with data-lanes on the DSI endpoint. vc4-kms-dsi-waveshare-panel: describe the adapter as the upstream waveshare,dsi2dpi/dsi2lvds bridge followed by a panel-simple panel. The 6.25inch B, 10.1inch E and 13.3inch 2 lane panels still use the downstream panel driver. The overlay parameters are unchanged. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
…ries panels" This reverts commit 762dbc5. The upstream gpio-waveshare-dsi driver handles the same controller, and the Waveshare overlays now use it. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Collaborator
Author
|
Some more detail on what changes and where it could go wrong. Everything here is from reading the code; none of it has been tested on a panel. Other user-visible changes
Risks
|
Contributor
|
FYI, @waveshare @EngineerWill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream now supports most Waveshare DSI panels: the DSI TOUCH panels in the jadard-jd9365da-h3, himax-hx8394, himax-hx83102, focaltech-ota7290b and ilitek-ili9881c drivers, the panel controller in gpio-waveshare-dsi, and the DSI-to-DPI/LVDS kits with the waveshare-dsi bridge plus panel-simple. This switches the two Waveshare overlays to those drivers and keeps the downstream drivers only for panels upstream lacks. It also fixes
waveshare,7.0-dsi-touch-a, which both ili9881c and the downstream v2 driver matched.The overlay parameters are unchanged.
vc4-kms-dsi-waveshare-panel-v2
data-laneson the DSI endpoint.vc4-kms-dsi-waveshare-panel
waveshare,dsi2dpiordsi2lvds) plus panel-simple: 2.8", 3.4", 4.0", 4.0" C, 5.0", 6.25", 7.0" C, 7.0" H, 7.9", 8.0", 8.8", 10.1", 11.9", 13.3" 4-lane.User-visible changes
LVDS-1/DPI-1instead ofDSI-1. Anything that names the output (video=, desktop screen layouts) needs updating.Testing
The two fixup commits trim the downstream panel drivers and will squash into "drm/panel: Add panel driver for Waveshare DSI touchscreens" at the next rebase.