Skip to content

dt-bindings: Fix dt_binding_check errors in downstream bindings - #7783

Merged
popcornmix merged 10 commits into
raspberrypi:rpi-7.4.yfrom
popcornmix:rpi-7.4.y-binding-fixes
Nov 20, 2026
Merged

popcornmix merged 10 commits into
raspberrypi:rpi-7.4.yfrom
popcornmix:rpi-7.4.y-binding-fixes

Conversation

@popcornmix

Copy link
Copy Markdown
Collaborator

Fixes for make dt_binding_check errors from downstream bindings. v7.4-rc3 is clean, so every error comes from downstream changes. All but one commit are fixups; they only touch downstream bindings, or the lines downstream added to upstream ones.

  • Revert "dt-bindings: ili9881c: add compatible string for new panels": raspberrypi,dsi-5inch and dsi-7inch are already upstream, so the entries were duplicated.
  • pwm-rp1.yaml: deleted. Upstream now has raspberrypi,rp1-pwm.yaml for the same compatible.
  • sony,imx500.yaml: reject unknown properties (rotation and orientation are still allowed), and accept 2 or 4 data lanes as the description says.
  • panel-dsi.yaml:
    • mode becomes an unordered list of flags.
    • The example panel sits on a DSI bus.
    • The panel-common properties are taken one by one, so its port definition no longer rejects data-lanes.
  • arducam-pivariety.yaml: unit address sensor@0c becomes sensor@c in the example.
  • ti,pcm3168a.yaml, raspberrypi,rp2040-gpio-bridge.yaml, snps,dwc3-common.yaml: add the missing property types.
  • snps,dwc3-common.yaml: document snps,axi-pipe-limit. The driver reads it and the BCM2712 RP1 device tree sets it, but no binding described it.
  • dongwoon,dw9807-vcm.yaml: remove a doubled blank line.

Testing

  • dt_binding_check: these errors are gone. The rest come from the Waveshare panel bindings (see Use upstream drivers for Waveshare DSI panels #7782) and from the panel-dsi example using a made-up panel name.
  • dtbs_check on the 13 BCM2711/BCM2712 Pi device trees against the changed bindings: 15 errors fewer, none added.
  • A trial rebase --autosquash applies every fixup to its target without conflicts.

This reverts commit f7ffb27.

raspberrypi,dsi-5inch and raspberrypi,dsi-7inch are already in the
upstream binding; the duplicate enum entries fail dt_binding_check.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Drop pwm-rp1.yaml: upstream now has pwm/raspberrypi,rp1-pwm.yaml for the
same compatible.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Disallow undocumented properties (with rotation/orientation from
video-interface-devices) and accept 2 or 4 data lanes, as described.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Make mode an unordered list of flags, put the example panel on a DSI bus,
and take the panel-common properties individually so its port definition
does not reject data-lanes.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
…MOS sensor binding

Drop the leading zero from the example unit address.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Give adc-force-cons and dac-force-cons a type.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Give fast_xfer_requires_i2c_lock and fast_xfer_recv_gpio_base types.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Remove a doubled blank line.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Give snps,enhanced-nak-fs-quirk and snps,enhanced-nak-hs-quirk a type.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Document snps,axi-pipe-limit, which the driver reads and the BCM2712 RP1
device tree sets, so dtbs_check accepts it.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
@popcornmix
popcornmix merged commit af46106 into raspberrypi:rpi-7.4.y Nov 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants