Skip to content

Fix note editor interaction inside dialogs - #5

Merged
backnotprop merged 1 commit into
plannotator:mainfrom
meowhib:fix/dialog-note-editor
Nov 21, 2026
Merged

backnotprop merged 1 commit into
plannotator:mainfrom
meowhib:fix/dialog-note-editor

Conversation

@meowhib

@meowhib meowhib commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Example: on doop.design whenever there's a dialog and you start to annotate, the input is not focused even when you click on it the cursor simply doesn't get focused.

clicking on "what should change?" doesn't do anything
image

after the changes
image

Summary

  • Native dialogs and popovers render in the browser’s top layer, above the document-root overlay regardless of its z-index. Native modals also make content outside the modal inert, and custom dialogs can pull focus back from the editor.
  • Mount the existing overlay inside the target’s dialog or popover and promote it with a manual popover. Keep the page’s dialog open while editing and preserve the draft if the page dismisses the dialog.
  • Add a local regression fixture and a release checklist entry.

Verification

  • bun test (68 passing), bun run compile, and bun run build
  • Chromium smoke test: click, type, and save on a regular page, in a native modal, in a modal inside open Shadow DOM, in a native popover, and in a custom focus-trapping dialog. Also verified that closing the native modal while editing preserves the draft.

@backnotprop
backnotprop merged commit a92d532 into plannotator:main Nov 21, 2026
1 check passed
@backnotprop backnotprop mentioned this pull request Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants