Skip to content

Fit bulk note deletion confirmation inside extension UI - #6

Merged
backnotprop merged 1 commit into
plannotator:mainfrom
meowhib:fix/bulk-clear-confirmation
Nov 21, 2026
Merged

backnotprop merged 1 commit into
plannotator:mainfrom
meowhib:fix/bulk-clear-confirmation

Conversation

@meowhib

@meowhib meowhib commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

before: this got stuck, clicking on any tabs or trying to close the tab with the keyboard shortcut doesn't work, so i have to close chrome and reopen.

image

after: simple contained dialog

image

Summary

  • Replace window.confirm() (which can be clipped in Chrome’s toolbar popup) with a shared, viewport-sized confirmation in the popup and notes workspace.
  • Name the site, file, or folder being cleared and explain that deletion cannot be undone. Focus Cancel first, support Escape, and keep errors in the dialog so users can retry.
  • Dismiss the confirmation if the notes workspace switches collections, so it never deletes a newly selected collection by mistake.

Verification

  • bun test (68 passing), bun run compile, and bun run build.
  • Chromium’s actual 252px toolbar popup: dialog fits, Cancel receives focus, and Escape dismisses without closing the popup or deleting notes.
  • Chromium extension smoke tests: cancel and focus restoration, failed request and retry, navigation while the confirmation is open, and site/file/folder deletion without affecting other collections.

@backnotprop
backnotprop merged commit bf6cbff into plannotator:main Nov 21, 2026
1 check passed
@backnotprop backnotprop mentioned this pull request Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants