Repository navigation
Conversation
build.yml is called from other repositories (x4 calls it at @main), but it used ./.github/actions/setup-cpp from the caller's workspace, copied from the caller's iris submodule. The workflow and the action it calls therefore came from different iris commits, and any change to their interface broke callers until they bumped the submodule. Check out .github/actions from job.workflow_repository at job.workflow_sha instead, so the action always matches the workflow. Callers no longer need a submodule bump to pick up CI changes. actionlint 1.7.12 does not yet know the job.workflow_* properties and reports them as undefined.
saki7
approved these changes
Nov 19, 2026
saki7
left a comment
Member
There was a problem hiding this comment.
I currently have no specific objection regarding this PR's implementation details. I understand the rationale too; dropping fragile @main dependency and sticking with some specific commit is much better without doubts.
Please just make sure the functional changes are minimal, and don't introduce unnecessarily large facility for achieving the goal I originally mentioned. If no design-related concerns emerge, feel free to self-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.ymlis a reusable workflow that x4 calls asiris-cpp/iris/.github/workflows/build.yml@main, but it ran./.github/actions/setup-cppfrom the caller's workspace, which the "Copy Local GitHub Actions" step filled from the caller'smodules/irissubmodule. The workflow and the action it calls therefore came from different iris commits: the workflow frommain, the action from whatever commit the caller's submodule points at. Any change to the action's interface, such as the input rename in #120, broke callers until they bumped the submodule.This replaces that step with a sparse checkout of
.github/actionsfromjob.workflow_repositoryatjob.workflow_sha, which identify the commit of the reusable workflow itself rather than the caller's (contexts reference), and runssetup-cppfrom there. Callers get the action matching the workflow they call without a submodule bump; the submodule is left to pin only the library.Stacked on #120; it will be retargeted to
mainonce #120 merges. The companion x4 PR relies on both.