Repository navigation
Conversation
The windows-2025-vs2026 runner image 20261116.315 replaces MSVC 14.51 with 14.52, so the pinned toolset_version 14.51 fails in setup once a job lands on it. iris's build.yml now selects the newest installed toolset matching a prefix and passes it to CMake's -T, replacing the compiler-toolset-version and vs-path inputs with msvc-toolset-prefix and msvc-platform-toolset; pass those instead. Requires iris-cpp/iris#120 and iris-cpp/iris#122 on iris main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to iris-cpp/iris#120 and iris-cpp/iris#122. The
windows-2025-vs2026runner image20261116.315replaces MSVC 14.51 with 14.52, so the MSVC jobs that pintoolset_version: 14.51fail in setup whenever they land on it (confirmed by rerunning iris's lastmainCI). iris#120 makesbuild.ymlselect the newest installed toolset matching a prefix and replaces itscompiler-toolset-versionandvs-pathinputs withmsvc-toolset-prefixandmsvc-platform-toolset; this passes"14.5"andv145accordingly.No submodule bump is needed: with iris#122,
build.ymlloadssetup-cppfrom its own commit rather than frommodules/iris.Merge after both iris PRs land on iris
main. Until then this PR's CI fails, becausebuild.yml@maindoes not define the new inputs yet.