Skip to content

Look for compiler issues only after the marker's output - #32

Merged
yaito3014 merged 1 commit into
mainfrom
fix/scan-after-marker
Nov 19, 2026
Merged

yaito3014 merged 1 commit into
mainfrom
fix/scan-after-marker

Conversation

@yaito3014

@yaito3014 yaito3014 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The job log was searched for warning: and error: from its first line, and CPPWARNINGNOTIFIER_LOG_MARKER only set the offset of the reported line. So anything earlier in the job counted as compiler output, including the runner's echo of a step's script. In yaito3014/polyfill and yaito3014/cats, a step whose script contains Write-Output "::error::No installed MSVC toolset..." made every MSVC job report an error, linked at a negative line, although they all compiled cleanly.

The scan now starts after the line the marker prints (the step's output, as opposed to the echoed echo "CPPWARNINGNOTIFIER_LOG_MARKER"), falls back to the start of the step that mentions the marker if that output is missing, and still scans the whole log when there is no marker. The reported line stays relative to the first line that mentions the marker, as before, so the links are unchanged. Warnings still take precedence over errors.

The scan moves from index.ts into scan.ts, with tests in scan.test.ts, and returns the matched line, which is still logged; dist is rebuilt. npm test passes.

The job log was searched from its first line, so any "warning:" or
"error:" earlier in the job counted as a compiler issue, including the
runner's echo of a step's script: a workflow step containing
Write-Output "::error::..." made every job using it report an error.
Search from the line the marker prints instead, falling back to the
start of the step that mentions it, and keep reporting the issue's line
relative to that step.

The scan moves to scan.ts with tests, and returns the matched line,
which is still logged.
@cppwarningnotifier

Copy link
Copy Markdown
EnvironmentC++20C++23C++26
ubuntu24.04GNU13Debug⚠️warning⚠️warning⚠️warning
Release⚠️warning⚠️warning⚠️warning
LLVM20Debug⚠️warning⚠️warning⚠️warning
Release⚠️warning⚠️warning⚠️warning

Updated at 2026-11-19 01:21:54 UTC for commit 57d3268

@yaito3014
yaito3014 merged commit 1100c11 into main Nov 19, 2026
13 checks passed
@yaito3014
yaito3014 deleted the fix/scan-after-marker branch November 19, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant