Repository navigation
Look for compiler issues only after the marker's output - #32
Merged
Merged
Conversation
The job log was searched from its first line, so any "warning:" or "error:" earlier in the job counted as a compiler issue, including the runner's echo of a step's script: a workflow step containing Write-Output "::error::..." made every job using it report an error. Search from the line the marker prints instead, falling back to the start of the step that mentions it, and keep reporting the issue's line relative to that step. The scan moves to scan.ts with tests, and returns the matched line, which is still logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job log was searched for
warning:anderror:from its first line, andCPPWARNINGNOTIFIER_LOG_MARKERonly set the offset of the reported line. So anything earlier in the job counted as compiler output, including the runner's echo of a step's script. In yaito3014/polyfill and yaito3014/cats, a step whose script containsWrite-Output "::error::No installed MSVC toolset..."made every MSVC job report an error, linked at a negative line, although they all compiled cleanly.The scan now starts after the line the marker prints (the step's output, as opposed to the echoed
echo "CPPWARNINGNOTIFIER_LOG_MARKER"), falls back to the start of the step that mentions the marker if that output is missing, and still scans the whole log when there is no marker. The reported line stays relative to the first line that mentions the marker, as before, so the links are unchanged. Warnings still take precedence over errors.The scan moves from
index.tsintoscan.ts, with tests inscan.test.ts, and returns the matched line, which is still logged;distis rebuilt.npm testpasses.