Repository navigation
Conversation
The link to a job's result pointed at the first successful step whose
name matched STEP_REGEX, so a workflow could not name another step
like its build step without taking the link away from it. A step can
instead print its own number after the marker, looked up from the jobs
API while it runs, when the step is the only one in_progress:
echo "CPPWARNINGNOTIFIER_LOG_MARKER $(gh api \
"repos/$GITHUB_REPOSITORY/actions/jobs/${{ job.check_run_id }}" \
--jq '.steps[] | select(.status == "in_progress") | .number')"
which needs actions: read and GH_TOKEN in the job. STEP_REGEX becomes
optional and is used only when the marker carries no number of a step
of the job, and a step it matches is now linked by its number rather
than by its position in the list, as step numbers can skip values.
The notifier's own CI now links through the numbered marker, without STEP_REGEX.
yaito3014
force-pushed
the
feat/step-from-marker
branch
from
November 19, 2026 06:25
9f51f03 to
1f92264
Compare
Member
Author
|
Reading the step number back from the API inside the job gave wrong links, because the API lags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links each result to the step number printed after the marker, instead of the first step whose name matches
STEP_REGEX, so other steps can be named freely (see the review on iris-cpp/iris#120). The step looks up its own number while it runs, as the job's onlyin_progressstep; this needsactions: readandGH_TOKEN:STEP_REGEXbecomes an optional fallback, and now links by step number rather than list position, since numbers can skip values. The TEST workflow uses the numbered marker withoutSTEP_REGEX.Stacked on #32. Verified with unit tests, and with probe runs on a fork (plain and reusable-workflow jobs, ubuntu and windows) that reported the correct step number. Not tested: the notifier end to end, as CI only runs for PRs into
main; fork PRs; self-hosted runners withoutgh. The 5tsc --noEmiterrors and the rollup TS5110 warning are pre-existing.