Repository navigation
Drop support for uap10.0 - #996
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
README.md:104 still lists the target framework moniker as .net10.0 instead of net10.0.
1 open issue
What changed in this PR
This PR drops the dedicated uap10.0 target from System.Linq.Dynamic.Core and removes its platform-specific implementation and sample applications.
Changes:
- Remove UAP build settings, dependencies, conditional code, and obsolete compatibility branches.
- Delete three UWP sample/test applications and update solution references, tests, and supported-framework documentation.
- Make NuGet publishing stop on build or pack failures and broaden coverage-file ignore patterns.
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/QueryableTests.FormattableString.cs | Remove UAP test compilation condition. |
| test/System.Linq.Dynamic.Core.Tests/EntitiesTests.FormattableString.cs | Remove UAP test compilation condition. |
| test-xamarin/WindowsUniversalTestApp16299/WindowsUniversalTestApp16299.csproj | Delete UWP test project. |
| test-xamarin/WindowsUniversalTestApp16299/WindowsAppCustomTypeProvider.cs | Delete UWP custom type provider. |
| test-xamarin/WindowsUniversalTestApp16299/TestEnum.cs | Delete test enum. |
| test-xamarin/WindowsUniversalTestApp16299/TestClassWithConstructor.cs | Delete constructor test model. |
| test-xamarin/WindowsUniversalTestApp16299/TestClass.cs | Delete test model. |
| test-xamarin/WindowsUniversalTestApp16299/Properties/Default.rd.xml | Delete .NET Native directives. |
| test-xamarin/WindowsUniversalTestApp16299/Properties/AssemblyInfo.cs | Delete application assembly metadata. |
| test-xamarin/WindowsUniversalTestApp16299/Package.appxmanifest | Delete UWP package manifest. |
| test-xamarin/WindowsUniversalTestApp16299/MainPage.xaml.cs | Delete page initialization. |
| test-xamarin/WindowsUniversalTestApp16299/MainPage.xaml | Delete page markup. |
| test-xamarin/WindowsUniversalTestApp16299/App.xaml.cs | Delete application and query examples. |
| test-xamarin/WindowsUniversalTestApp16299/App.xaml | Delete application markup. |
| test-xamarin/WindowsUniversalTestApp14393/WindowsUniversalTestApp14393.csproj | Delete UWP test project. |
| test-xamarin/WindowsUniversalTestApp14393/WindowsAppCustomTypeProvider.cs | Delete UWP custom type provider. |
| test-xamarin/WindowsUniversalTestApp14393/TestEnum.cs | Delete test enum. |
| test-xamarin/WindowsUniversalTestApp14393/TestClassWithConstructor.cs | Delete constructor test model. |
| test-xamarin/WindowsUniversalTestApp14393/TestClass.cs | Delete test model. |
| test-xamarin/WindowsUniversalTestApp14393/Properties/Default.rd.xml | Delete .NET Native directives. |
| test-xamarin/WindowsUniversalTestApp14393/Properties/AssemblyInfo.cs | Delete application assembly metadata. |
| test-xamarin/WindowsUniversalTestApp14393/Package.appxmanifest | Delete UWP package manifest. |
| test-xamarin/WindowsUniversalTestApp14393/MainPage.xaml.cs | Delete page initialization. |
| test-xamarin/WindowsUniversalTestApp14393/MainPage.xaml | Delete page markup. |
| test-xamarin/WindowsUniversalTestApp14393/App.xaml.cs | Delete application and query examples. |
| test-xamarin/WindowsUniversalTestApp14393/App.xaml | Delete application markup. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/Properties/Default.rd.xml | Delete .NET Native directives. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/Properties/AssemblyInfo.cs | Delete application assembly metadata. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/Package.appxmanifest | Delete UWP package manifest. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/MainPage.xaml.cs | Delete Xamarin.Forms page initialization. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/MainPage.xaml | Delete UWP page markup. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/ExpressionSample.UWP.csproj | Delete UWP sample project. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/App.xaml.cs | Delete UWP application lifecycle code. |
| test-xamarin/ExpressionSample/ExpressionSample.UWP/App.xaml | Delete application markup. |
| System.Linq.Dynamic.Core.sln | Remove ExpressionSample.UWP registration and configurations. |
| src/System.Linq.Dynamic.Core/Util/RuntimeInformationUtils.cs | Remove UAP runtime-detection condition. |
| src/System.Linq.Dynamic.Core/TypeConverters/TypeConverterFactory.cs | Remove Silverlight converter fallback. |
| src/System.Linq.Dynamic.Core/System.Linq.Dynamic.Core.csproj | Remove UAP target, settings, and dependencies. |
| src/System.Linq.Dynamic.Core/Res.cs | Remove UAP from unsupported-feature message. |
| src/System.Linq.Dynamic.Core/ParsingConfig.cs | Remove UAP custom-provider condition. |
| src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs | Simplify reflection and numeric-type conditions. |
| src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs | Remove UAP reflection conditions. |
| src/System.Linq.Dynamic.Core/Parser/NumberParser.cs | Remove UAP number-parsing condition. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs | Remove UAP expression-promotion condition. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs | Remove UAP projection and member-access branches. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs | Remove UAP dynamic-expression restriction. |
| src/System.Linq.Dynamic.Core/Parser/ConstantExpressionWrapper.cs | Remove UAP import condition. |
| src/System.Linq.Dynamic.Core/GroupResult.cs | Remove Silverlight key-type condition. |
| src/System.Linq.Dynamic.Core/Exceptions/ParseException.cs | Simplify legacy serialization conditions. |
| src/System.Linq.Dynamic.Core/DynamicQueryableWithFormattableStringExtensions.cs | Remove UAP compilation condition. |
| src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs | Remove UAP comparer fallback and Silverlight guards. |
| src/System.Linq.Dynamic.Core/DynamicGetMemberBinder.cs | Remove UAP compilation exclusion. |
| src/System.Linq.Dynamic.Core/DynamicClassFactory.cs | Remove UAP compilation guards. |
| src/System.Linq.Dynamic.Core/DynamicClass.uap.cs | Delete UAP-specific dynamic class. |
| src/System.Linq.Dynamic.Core/DynamicClass.cs | Remove UAP compilation exclusion. |
| src/System.Linq.Dynamic.Core/DefaultAssemblyHelper.cs | Remove obsolete platform conditions. |
| src/System.Linq.Dynamic.Core/CustomTypeProviders/AbstractDynamicLinqCustomTypeProvider.cs | Remove UAP type-discovery condition. |
| src/System.Linq.Dynamic.Core/Compatibility/TypeExtensions.cs | Limit compatibility helpers to .NET Standard 1.3. |
| src/System.Linq.Dynamic.Core/Compatibility/CustomTypeConverterExtensions.cs | Delete Silverlight converter helper. |
| src/System.Linq.Dynamic.Core/Compatibility/CustomTypeBuilderExtensions.cs | Remove obsolete platform conditions. |
| src/System.Linq.Dynamic.Core/Compatibility/CustomIntrospectionExtensions.cs | Remove Silverlight and Windows Phone conditions. |
| src/System.Linq.Dynamic.Core/Compatibility/CodeAnalysis/NotNullWhenAttribute.cs | Remove UAP compatibility condition. |
| src/System.Linq.Dynamic.Core/AssemblyBuilderFactory.cs | Remove UAP and Silverlight guards. |
| src/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore3/EFDynamicQueryableWithFormattableStringExtensions.cs | Remove UAP compilation condition. |
| src/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore3/EFDynamicQueryableExtensions.cs | Remove UAP reflection and Silverlight tracing conditions. |
| README.md | Remove UAP support listing and add .NET 10. |
| .gitignore | Remove Silverlight rule and generalize coverage ignores. |
| .github/workflows/PublishToNuGet.yml | Stop publishing workflow on build or pack failures. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.