Repository navigation
Copy sector in chunks with smaller NVM_CACHE #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vhdirk
wants to merge
1
commit into
wolfSSL:master
Choose a base branch
from
vhdirk:nvm-cache-chunks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New NVM_CACHE_SIZE guard permits sub-sector cache that hal_set_key overflows with key material · Buffer overflows
The guard now accepts
NVM_CACHE_SIZE < WOLFBOOT_SECTOR_SIZE, but underEXT_ENCRYPTEDhal_set_keyusesNVM_CACHEasENCRYPT_CACHEand copies/writes a full sector (lines 2990-3011). This overflows it, and key/nonce bytes stay unscrubbed in the RAM next to it.Suggested fix: Add an
#errorwhenEXT_ENCRYPTEDkey storage usesNVM_CACHEwithNVM_CACHE_SIZE < WOLFBOOT_SECTOR_SIZE, or porthal_set_keytonvm_sector_copy_with_patch.Basis: ISO C11 6.5.6p8: forming or dereferencing a pointer past the end of an array object (here the NVM_CACHE_SIZE-byte NVM_CACHE) is undefined behavior.
Related known findings (similar but distinct; listed for context, not part of this finding)