Repository navigation
fix(vite): preserve SSR entry import order when registering manifests - #725
Open
nagahara-naoki wants to merge 1 commit into
Open
nagahara-naoki wants to merge 1 commit into
nagahara-naoki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone!
An SSR entry can import
@angular/compilerbefore@angular/ssr/nodeto initialize JIT support for externalized Angular libraries. The manifest plugin currently prepends its own import of@angular/ssr. With Angular 21.2.1 this makes the server fail on startup withJIT compilation failed for injectable [class PlatformLocation], even though the entry imports the compiler first.Changes
Append a static import of a virtual module to the server entry. The entry's original dependencies now evaluate first, then the virtual module registers both manifests before the entry constructs
AngularNodeAppEngine. The virtual module resolves Angular and the bootstrap relative to the original entry.The regression test builds and executes an SSR entry and records the evaluation order. It uses JSX in a
.jsentry to exercise a custom Rolldown module type.Checks
ssr-manifest.test.tspassed. On the base commit, the new test recordsssrbeforecompiler.vite build --app --watchupdated the client asset embedded in the server bundle.Related to #60.