Skip to content

fix(template): Match kuttl 0.23+ namespace log lines in auto-retry-tests - #665

Open
lfrancke wants to merge 2 commits into
mainfrom
push-ntxmkuyrrmxq
Open

lfrancke wants to merge 2 commits into
mainfrom
push-ntxmkuyrrmxq

Conversation

@lfrancke

@lfrancke lfrancke commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description

kuttl 0.23 quotes the namespace in its "Creating namespace" log line and drops the colon, and 0.26 renames generated namespaces from kuttl-test- to kuttl--. With the old pattern a retried test that passed would leave its namespace behind and a failed test reported no namespace for debugging.

The new pattern now accepts both formats.

Tip

prek complains about pre-existing stuff in the retry script. So I'll include those in the PR. Just so it's green.

kuttl 0.23 quotes the namespace in its "Creating namespace" log line and drops the colon, and 0.26 renames generated namespaces from kuttl-test-<pet> to kuttl-<pet>-<suffix>.
With the old pattern a retried test that passed would leave its
namespace behind and a failed test reported no namespace for debugging.

The new pattern now accepts both formats.
@lfrancke lfrancke self-assigned this Nov 18, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Nov 18, 2026
…y's ruff rules

Touching the file for the kuttl namespace pattern made prek lint all of it, and the existing code
broke 53 rules. Annotations use the built-in generics and `| None`, kept importable on Python 3.9
by postponed evaluation; subprocess calls say check=False, which is what they relied on; the broad
excepts stay, marked, because the retry run reports an error and carries on.

# Regex patterns
NAMESPACE_PATTERN = r"Creating namespace: (kuttl-test-[^\s]+)"
# kuttl 0.23 and later log `Creating namespace "<name>"`,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to prek the PR is now polluted. This is the relevant change in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

1 participant