Repository navigation
Conversation
kuttl 0.23 quotes the namespace in its "Creating namespace" log line and drops the colon, and 0.26 renames generated namespaces from kuttl-test-<pet> to kuttl-<pet>-<suffix>. With the old pattern a retried test that passed would leave its namespace behind and a failed test reported no namespace for debugging. The new pattern now accepts both formats.
…y's ruff rules Touching the file for the kuttl namespace pattern made prek lint all of it, and the existing code broke 53 rules. Annotations use the built-in generics and `| None`, kept importable on Python 3.9 by postponed evaluation; subprocess calls say check=False, which is what they relied on; the broad excepts stay, marked, because the retry run reports an error and carries on.
lfrancke
commented
Nov 18, 2026
|
|
||
| # Regex patterns | ||
| NAMESPACE_PATTERN = r"Creating namespace: (kuttl-test-[^\s]+)" | ||
| # kuttl 0.23 and later log `Creating namespace "<name>"`, |
Member
Author
There was a problem hiding this comment.
Due to prek the PR is now polluted. This is the relevant change in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kuttl 0.23 quotes the namespace in its "Creating namespace" log line and drops the colon, and 0.26 renames generated namespaces from kuttl-test- to kuttl--. With the old pattern a retried test that passed would leave its namespace behind and a failed test reported no namespace for debugging.
The new pattern now accepts both formats.
Tip
prek complains about pre-existing stuff in the retry script. So I'll include those in the PR. Just so it's green.