Repository navigation
Conversation
humantime with jiff
|
I assume we're not merging until the release branches are cut? |
|
Correct |
There was a problem hiding this comment.
I'm not a huge fan that we now have a fallible path for what is basically only a debug log statement.
I also looked at this briefly and the SystemTime comes from deep within x509-cert. We should also look into what other options they might expose which don't require a fallible path.
| /// Rotate the certificate when less than 1/6 of its lifetime remains (4 hours for the current 24h | ||
| /// lifetime). Derived from [`CERTIFICATE_LIFETIME_HOURS`] so it scales if the lifetime changes. | ||
| const CERTIFICATE_EXPIRY_BUFFER_HOURS: u64 = CERTIFICATE_LIFETIME_HOURS * 60 / 6; | ||
| const CERTIFICATE_EXPIRY_BUFFER_MINUTES: u64 = CERTIFICATE_LIFETIME_HOURS * 60 / 6; |
There was a problem hiding this comment.
this was just a rename, the name was wrong previously
I noticed we actually don't need |
humantime with jiffhumantime dependency
humantime dependencyhumantime dependency
Description
Fixes https://rustsec.org/advisories/RUSTSEC-2026-0542
cargo deny fails because we need stackabletech/operator-templating#664 first.
We can force-merge if needed
Definition of Done Checklist
Author
Reviewer
Acceptance