Repository navigation
fix: Write files without following symlinks - #450
Merged
Merged
Conversation
This applies a similar treatment from the secret-operator (see stackabletech/secret-operator#775) to the listener-operator as well. The implementation here needed to be adjusted slightly because the listener-operator creates multiple directories and multiple files at different levels of nesting.
Without that function, the root target_dir wasn't created and all following code didn't run (like opening the root dir). This is because listener-operator previously implicitly created the target_dir via a tokio::fs::create_dir_all call when the "addresses" directory was first created. In general, I would suggest to structure the listener-operator more similar to secret-operator which is currently not the case.
Techassi
marked this pull request as ready for review
November 17, 2026 12:12
NickLarsenNZ
previously approved these changes
Nov 17, 2026
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGMT
I assume tests all pass (I saw earlier ones pass, but changes had been made since).
Techassi
force-pushed
the
fix/write-files-without-following-symlinks
branch
from
November 17, 2026 14:45
8d0c91f to
44f6e8b
Compare
Member
Author
They did pass yes, but happy to run them again just to make sure as they are fairly quick. |
Member
Author
|
All tests passed locally: |
NickLarsenNZ
approved these changes
Nov 17, 2026
Member
Release notePreviously, the listener volume driver followed symbolic links when it wrote listener addresses and ports into a Pod's volume. With this release, it no longer follows symbolic links inside the volume and only writes into regular files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Do we want to add unit tests?
This applies a similar treatment from the secret-operator (see stackabletech/secret-operator#775) to the listener-operator as well.
The implementation here needed to be adjusted significantly because the listener-operator creates multiple directories and multiple files at different levels of nesting.
The integration tests succeeded locally.