Skip to content

fix: Write files without following symlinks - #450

Merged
Techassi merged 12 commits into
mainfrom
fix/write-files-without-following-symlinks
Nov 17, 2026
Merged

Techassi merged 12 commits into
mainfrom
fix/write-files-without-following-symlinks

Conversation

@Techassi

@Techassi Techassi commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Note

Do we want to add unit tests?

This applies a similar treatment from the secret-operator (see stackabletech/secret-operator#775) to the listener-operator as well.

The implementation here needed to be adjusted significantly because the listener-operator creates multiple directories and multiple files at different levels of nesting.

The integration tests succeeded locally.

This applies a similar treatment from the secret-operator (see
stackabletech/secret-operator#775) to the
listener-operator as well.

The implementation here needed to be adjusted slightly because the
listener-operator creates multiple directories and multiple files
at different levels of nesting.
@Techassi Techassi self-assigned this Nov 16, 2026
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Nov 16, 2026
Without that function, the root target_dir wasn't created and all
following code didn't run (like opening the root dir). This is
because listener-operator previously implicitly created the
target_dir via a tokio::fs::create_dir_all call when the "addresses"
directory was first created.

In general, I would suggest to structure the listener-operator more
similar to secret-operator which is currently not the case.
@Techassi
Techassi marked this pull request as ready for review November 17, 2026 12:12
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Nov 17, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

I assume tests all pass (I saw earlier ones pass, but changes had been made since).

Comment thread deny.toml Resolved
Comment thread typos.toml Resolved
@Techassi
Techassi force-pushed the fix/write-files-without-following-symlinks branch from 8d0c91f to 44f6e8b Compare November 17, 2026 14:45
@Techassi

Copy link
Copy Markdown
Member Author

I assume tests all pass (I saw earlier ones pass, but changes had been made since).

They did pass yes, but happy to run them again just to make sure as they are fairly quick.

@Techassi

Copy link
Copy Markdown
Member Author

All tests passed locally:

--- PASS: kuttl (80.33s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-false_loadbalancer-allocatenodeports-false (7.67s)
        --- PASS: kuttl/harness/overrides (6.50s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-Hostname (52.69s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-IP (39.01s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-false_loadbalancer-allocatenodeports-true (7.64s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-HostnameConservative (27.15s)
PASS

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 17, 2026
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Nov 17, 2026
Merged via the queue into main with commit e586203 Nov 17, 2026
13 checks passed
@Techassi
Techassi deleted the fix/write-files-without-following-symlinks branch November 17, 2026 15:01
@lfrancke

Copy link
Copy Markdown
Member

Release note

Previously, the listener volume driver followed symbolic links when it wrote listener addresses and ports into a Pod's volume. With this release, it no longer follows symbolic links inside the volume and only writes into regular files.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 19, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/26.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants