Skip to content

feat(olm): Set createdAt and the CSI feature annotation - #449

Merged
lfrancke merged 4 commits into
mainfrom
push-zpqzuokwmxtr
Nov 18, 2026
Merged

lfrancke merged 4 commits into
mainfrom
push-zpqzuokwmxtr

Conversation

@lfrancke

@lfrancke lfrancke commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Description

This changes the OLM bundles.
If accepted I'll do the same for secret and stackable-utils.
This sets the CSI flag (for secret as well then later) and the createdAt tag based on the git tag.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@lfrancke lfrancke self-assigned this Nov 12, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Nov 12, 2026
@adwk67
adwk67 self-requested a review November 18, 2026 13:07
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 18, 2026
adwk67
adwk67 previously approved these changes Nov 18, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What was tested:

  • Built a test bundle from the certified 26.7.0 bundle plus only the two new annotations (csi: 'true', createdAt), version bumped to 26.7.1. (Running the script against main, or even the 26.7.0 chart, brings in other changes, e.g. from #443.)

  • Built a test FBC with both bundles

  • Installed 26.7.0 from the test catalog, upgraded to 26.7.1: CSV replaced cleanly, annotations present on the cluster, CSI plugin still mounts listener volumes.

  • Ran the kuttl openshift suite on the upgraded install

  • Ran preflight check operator on the bundle: passed. RequiredAnnotations treats csi as optional, must be true/false.

  • Ran Red Hat's certification CI pipeline locally with submit=false: 15/15 tasks passed (the submit-only tasks were skipped). No CSI-specific check found in the pipeline or in preflight.

  • Not covered: Red Hat's hosted pipeline (only runs on a real submission), and how the console displays the annotations (test cluster has no console).

@adwk67

adwk67 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Changelog?

@lfrancke

Copy link
Copy Markdown
Member Author

Holy shit, thank you. I did not run all those tests. I only built a test bundle.

I can add a changelog

@lfrancke
lfrancke added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 299357e Nov 18, 2026
11 checks passed
@lfrancke
lfrancke deleted the push-zpqzuokwmxtr branch November 18, 2026 16:40
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Nov 18, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants