Repository navigation
feat(olm): Set createdAt and the CSI feature annotation - #449
Conversation
adwk67
left a comment
There was a problem hiding this comment.
LGTM
What was tested:
-
Built a test bundle from the certified 26.7.0 bundle plus only the two new annotations (csi: 'true', createdAt), version bumped to 26.7.1. (Running the script against main, or even the 26.7.0 chart, brings in other changes, e.g. from #443.)
-
Built a test FBC with both bundles
-
Installed 26.7.0 from the test catalog, upgraded to 26.7.1: CSV replaced cleanly, annotations present on the cluster, CSI plugin still mounts listener volumes.
-
Ran the kuttl openshift suite on the upgraded install
-
Ran preflight check operator on the bundle: passed. RequiredAnnotations treats csi as optional, must be true/false.
-
Ran Red Hat's certification CI pipeline locally with submit=false: 15/15 tasks passed (the submit-only tasks were skipped). No CSI-specific check found in the pipeline or in preflight.
-
Not covered: Red Hat's hosted pipeline (only runs on a real submission), and how the console displays the annotations (test cluster has no console).
|
Changelog? |
|
Holy shit, thank you. I did not run all those tests. I only built a test bundle. I can add a changelog |
Description
This changes the OLM bundles.
If accepted I'll do the same for secret and stackable-utils.
This sets the CSI flag (for secret as well then later) and the
createdAttag based on the git tag.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker