Skip to content

Set up shared components and start with ContextMenu as a first - #485

Open
Bohreromir wants to merge 4 commits into
mainfrom
refactor-370-popover-layering
Open

Bohreromir wants to merge 4 commits into
mainfrom
refactor-370-popover-layering

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Description

First step towards #366 : sets up a layer for shared UI components and moves the context menus into it

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.85% 9310 / 13721
🔵 Statements 66.81% 12482 / 18682
🔵 Functions 68.81% 2996 / 4354
🔵 Branches 58.03% 5256 / 9057
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/dashboard/AddBookmarkModal.svelte 99.24% 88.73% 100% 100% 143, 153
src/lib/components/layout/SessionExpiredModal.svelte 0% 100% 0% 0% 11-53
src/lib/components/layout/sidebar/Sidebar.svelte 0% 0% 0% 0% 116-288
src/lib/components/storage/StorageSearch.svelte 92.15% 70% 92% 88.42% 78-79, 82-83, 180-181, 139-149, 162
src/lib/components/storage/StorageSearchHistory.svelte 98.33% 83.33% 95% 100% 60
src/lib/components/storage/StorageSearchHistoryEntry.svelte 97.34% 76.66% 93.54% 96.66% 36-41, 45
src/lib/components/storage/explorer/FileExplorer.svelte 86.11% 64.54% 84.48% 86.23% 68, 76-80, 84, 104, 135-144, 149, 152, 327-328, 343-344, 417
src/lib/components/storage/explorer/StorageBreadcrumb.svelte 88.38% 70.13% 92.79% 83.85% 124, 175, 177, 179, 205-223, 304, 306, 327, 329, 395, 397, 347-348, 351, 354-356, 359, 428, 430, 446, 448, 488, 467-470, 604, 627, 635-625, 580
src/lib/components/storage/explorer/TabBar.svelte 59.52% 33.33% 65.51% 61.53% 32-36, 42-62, 115, 122-127, 161-163
src/lib/components/storage/landing/BucketGrid.svelte 65.95% 75% 59.09% 62.06% 15, 22-32, 41-53, 87, 45
src/lib/components/storage/modals/AddBucketModal.svelte 94.44% 90% 94.44% 95.08% 40, 55, 57-62
src/lib/components/storage/modals/CreateModal.svelte 90.36% 75% 90.47% 95.83% 41, 100, 99, 113, 112
src/lib/components/storage/modals/DeleteConfirmModal.svelte 100% 100% 100% 100%
src/lib/components/storage/modals/DeleteConnectionModal.svelte 2.38% 0% 7.14% 4.28% 21-42, 48-130
src/lib/components/storage/modals/DetailsModal.svelte 0% 0% 0% 0% 25-151
src/lib/components/storage/modals/MoveConfirmModal.svelte 0% 0% 0% 0% 25-79
src/lib/components/storage/modals/PreviewModal.svelte 74.35% 65.39% 80.19% 71.01% 152, 162, 164, 168, 180, 213-218, 262-264, 308, 339-350, 356, 432, 453-545, 549, 553-555, 563, 579-580, 599-615, 623-640, 646-647, 653, 673-701, 729-731, 755-759, 754, 769, 768, 728, 799, 841, 840, 837, 940-945, 952-953, 939, 1027-1024
src/lib/components/storage/modals/RenameModal.svelte 88.6% 80% 85% 95.83% 52, 71, 102, 101, 115, 114
src/lib/components/storage/modals/UnsavedConfirmDialog.svelte 9.09% 100% 25% 13.33% 17-35
src/lib/components/storage/modals/details/Treemap.svelte 0% 0% 0% 0% 14-227
src/lib/components/storage/modals/shared/ConflictResolutionDialog.svelte 69.27% 55.95% 73.01% 75.49% 77-90, 95, 127, 131-132, 141, 143, 165-171, 206, 205, 212, 211, 227-240, 232, 253-254
src/lib/components/storage/modals/upload/UploadModal.svelte 74.04% 47.01% 79.23% 70.03% 96-97, 129, 140-142, 157-159, 166-168, 172-173, 200-202, 217-221, 281-334, 348-350, 363-391, 408, 412, 532-535, 614-625
src/lib/components/storage/sidebar/BucketList.svelte 84.1% 69.23% 85.71% 78.76% 36-37, 65-74, 85-102, 125, 141, 151, 153, 233, 234, 236
src/lib/components/storage/sidebar/StorageConnectionSidebar.svelte 61.61% 22% 58.06% 56.55% 52-67, 72-86, 95-100, 104-115, 120-132, 146-153, 145, 159-158, 178-180, 267-279, 293, 303, 304, 319, 322
src/lib/components/ui/ContextMenu.svelte 96.74% 90.24% 94.28% 98.75% 26, 81, 184, 150
src/lib/storage/types.ts 100% 100% 100% 100%
src/routes/(app)/settings/connections/+page.svelte 0% 0% 0% 0% 16-170
src/routes/(app)/settings/connections/[id]/edit/+page.svelte 0% 0% 0% 0% 19-322
src/routes/(app)/trino/+page.svelte 0% 0% 0% 0% 401-817
Generated in workflow #1331 for commit 0d36d5a by the Vitest Coverage Report Action

Move Modal, Tooltip, TooltipTrigger and TabBar into src/lib/components/ui/, enforce with ESLint that ui/ components do not import app code, and document the component layers in AGENTS.md.

Part of #366 and #370
ui/ContextMenu uses popover="auto", so the browser puts it in the top layer and handles outside clicks, Escape and closing other menus. A menu opened by a right-click waits for the pointer release, which would otherwise light-dismiss it straight away. The explorer, tab and breadcrumb menus use it instead of the old explorer ContextMenu and its click-catcher.

Part of #366 and #370
…ntextMenu

The bucket grid, treemap, bucket sidebar, saved-connections sidebar and settings connections page use ui/ContextMenu, which removes FloatingMenu and the remaining click-catchers. The delete-connection modal keeps its own target, so it opens again after being dismissed with Escape.

Part of #366 and #370
@Bohreromir
Bohreromir force-pushed the refactor-370-popover-layering branch from 573c817 to 0d36d5a Compare November 19, 2026 13:35
@Bohreromir Bohreromir linked an issue Nov 19, 2026 that may be closed by this pull request
@Bohreromir Bohreromir self-assigned this Nov 19, 2026
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 19, 2026
@Bohreromir
Bohreromir marked this pull request as ready for review November 19, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

Setup shared components and start with context menus

1 participant