Repository navigation
Set up shared components and start with ContextMenu as a first - #485
Open
Bohreromir wants to merge 4 commits into
Open
Bohreromir wants to merge 4 commits into
Bohreromir wants to merge 4 commits into
Conversation
ui/ContextMenu uses popover="auto", so the browser puts it in the top layer and handles outside clicks, Escape and closing other menus. A menu opened by a right-click waits for the pointer release, which would otherwise light-dismiss it straight away. The explorer, tab and breadcrumb menus use it instead of the old explorer ContextMenu and its click-catcher. Part of #366 and #370
…ntextMenu The bucket grid, treemap, bucket sidebar, saved-connections sidebar and settings connections page use ui/ContextMenu, which removes FloatingMenu and the remaining click-catchers. The delete-connection modal keeps its own target, so it opens again after being dismissed with Escape. Part of #366 and #370
Bohreromir
force-pushed
the
refactor-370-popover-layering
branch
from
November 19, 2026 13:35
573c817 to
0d36d5a
Compare
3 tasks
Bohreromir
marked this pull request as ready for review
November 19, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First step towards #366 : sets up a layer for shared UI components and moves the context menus into it
Docs
Release note
Checklist
Author
Reviewer
Acceptance