Skip to content

fix(storage): Refresh the listing after a cancelled upload - #479

Draft
Bohreromir wants to merge 1 commit into
mainfrom
fix/upload-cancel-refresh
Draft

Bohreromir wants to merge 1 commit into
mainfrom
fix/upload-cancel-refresh

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Cancelling an upload closed the modal, but only the Done button refreshed the listing, so files uploaded before the cancel stayed hidden.

Closing with Escape or the backdrop did not cancel at all: they now all trigger user confirmation to abort

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.73% 9323 / 13764
🔵 Statements 66.66% 12516 / 18775
🔵 Functions 68.5% 2997 / 4375
🔵 Branches 57.6% 5258 / 9127
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/storage/modals/StorageModals.svelte 45.83% 64.4% 41.86% 51.66% 58, 64, 70, 76, 82, 89-90, 99-100, 118, 121, 126-127, 125-140, 135-158, 155-170, 167-181, 178
src/lib/components/storage/modals/upload/UploadModal.svelte 79.73% 52.07% 83.08% 76.09% 109-110, 142, 153-155, 170-172, 179-181, 185-186, 213-215, 233-237, 306-359, 394, 403-408, 417-431, 448, 572-575, 665-668
src/lib/storage/state.svelte.ts 78.02% 65.82% 85.4% 79.2% 483-488, 697-727, 765-767, 807-809, 844-846, 986-988, 80, 91, 129, 168-171, 176, 181-184, 294, 313, 327-328, 337, 374, 386, 390, 402, 439, 443, 484-487, 517-518, 526-532, 535-536, 547-548, 551-556, 586, 599, 606-640, 644, 652, 660, 662, 678, 680, 688-725, 741-742, 759-766, 771, 780, 797, 798, 808, 845, 857, 884-886, 907-919, 943, 945, 946, 954, 959, 974, 977-978, 987, 996
Generated in workflow #1323 for commit 014d5a4 by the Vitest Coverage Report Action

Cancelling an upload closed the modal, but only the Done button refreshed
the listing, so files uploaded before the cancel stayed hidden. Closing
with Escape or the backdrop did not cancel at all: the remaining files
kept uploading in the background.

Closing the modal now stops the upload however it is closed and aborts
the requests in flight; if any file was uploaded, the listing is
refreshed. The close button, Escape and the backdrop ask first, like
leaving the page does; the Cancel button stops right away.
@Bohreromir
Bohreromir force-pushed the fix/upload-cancel-refresh branch from 59c7372 to 014d5a4 Compare November 17, 2026 15:18
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

1 participant