Repository navigation
fix(storage): Refresh the listing after a cancelled upload - #479
Draft
Bohreromir wants to merge 1 commit into
Draft
Bohreromir wants to merge 1 commit into
Bohreromir wants to merge 1 commit into
Conversation
Cancelling an upload closed the modal, but only the Done button refreshed the listing, so files uploaded before the cancel stayed hidden. Closing with Escape or the backdrop did not cancel at all: the remaining files kept uploading in the background. Closing the modal now stops the upload however it is closed and aborts the requests in flight; if any file was uploaded, the listing is refreshed. The close button, Escape and the backdrop ask first, like leaving the page does; the Cancel button stops right away.
Bohreromir
force-pushed
the
fix/upload-cancel-refresh
branch
from
November 17, 2026 15:18
59c7372 to
014d5a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cancelling an upload closed the modal, but only the Done button refreshed the listing, so files uploaded before the cancel stayed hidden.
Closing with Escape or the backdrop did not cancel at all: they now all trigger user confirmation to abort
Docs
Release note
Checklist
Author
Reviewer
Acceptance