You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix validation errors in UniFi, WasabiWACM and Steam - #200
This PR fixes three plugins that fail squaredup validate on main against the current plugin schema. That keeps them out of the SmartViz conversion (#199), and their next deploy would fail too.
UniFi: five data streams still use the old flat paging keys (pagingConfig_mode, pagingConfig_offset_base), which the schema no longer accepts. They all mean "no paging", so they now use "paging": { "mode": "none" }, as every other plugin does.
Steam: the gameNews stream declares an empty "paging": {} with no mode. It now says "none" too.
WasabiWACM: the import mapped each account's address state to a property called state, which the graph reserves. That fails the import, and DEV now refuses to deploy the plugin at all ("Invalid import definitions"). The property is now region, read from the same state column, as the build-plugin guidance suggests for an address.
Note
This PR changes 3 plugins, so the single-plugin CI check will fail. An admin will need to override it, as for the SmartViz waves.
Plugin name (each gets a patch bump): UniFi 1.0.8, WasabiWACM 1.0.4, Steam 1.0.4
Type of change:
Bug fix
New datastream
Enhancement to existing datastream
Performance improvement
Documentation / metadata / logo
Other (please describe):
🧪 Testing
squaredup validate now passes for all three plugins; on main all three fail.
WasabiWACM: I deployed the fixed version to a DEV organization with demo data and re-indexed it. All five import steps succeed, including the three that map region. The main version can't be deployed to DEV at all.
UniFi and Steam: the change only restates "no paging" in the current format, so requests are unchanged. I haven't run them against live UniFi or Steam accounts.
⚠️ Breaking changes
Does this PR introduce any breaking changes?
No
Yes (please describe):
WasabiWACM's control, channel and sub-account objects get a new region property; their IDs, names and types don't change, so dashboards, scopes and perspectives keep working. The graph only accepts a health value (success, info, warning, error, unknown) in state, so an address state never reached any object: an account with one failed the import instead. Nothing can rely on the old mapping. Organizations whose accounts have a state will now import those objects where the import failed before.
📚 Documentation
Documentation updated
No documentation changes needed
✅ Checklist
This PR changes a single plugin only
No secrets or credentials included
Plugin, datastream and UI naming follow SquaredUp guidelines
Corrected Wasabi WACM account data mapping so the source state value appears in the region field for control, channel and sub-accounts.
Configuration
Updated Steam game news and UniFi host, site and WAN streams to use non-paged retrieval. This aligns their paging settings and avoids applying paging to these data streams.
All three fail `squaredup validate` on main against the current plugin
schema, which keeps them out of the SmartViz conversion and would fail
their next deploy.
UniFi's five data streams still used the old flat paging keys
(pagingConfig_mode, pagingConfig_offset_base), which the schema no
longer accepts. They all meant "no paging", so they now use the paging
block every other plugin uses. Steam's gameNews stream declared an
empty paging block with no mode; it now says "none" too.
WasabiWACM mapped an account's address state to a property called
"state", which the graph reserves: it fails the import, and DEV now
refuses to deploy the plugin at all ("Invalid import definitions").
The property is now "region", read from the same "state" column, as
the build-plugin guidance suggests for an address. A demo-data import
on DEV succeeds for all five steps with the change.
Each plugin gets a patch bump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DsSxB9yhNwiJp2KU2D8Upi
No actionable comments were generated in the recent review.
Walkthrough
Steam and UniFi data streams now express paging mode none through a paging object. Wasabi WACM account mappings now map the source state field to the output region property.
Steam and UniFi data streams use a paging object with mode none. The Steam metadata version changes to 1.0.4, and the UniFi metadata version changes to 1.0.8.
Wasabi WACM account mappings
Layer / File(s)
Summary
Account mappings and plugin version plugins/WasabiWACM/v1/indexDefinitions/default.json, plugins/WasabiWACM/v1/metadata.json
The controlAccounts, channelAccounts and subAccounts mappings map source state to output region. The metadata version changes to 1.0.4.
Merge Risk: Low · up to 29d8e
This updates three plugins to the current schema. The WasabiWACM property rename from state to region could affect existing dashboards or imports that reference the old name. The author's demo-data deployment succeeded, so the remaining risk is small. Confirm that no existing dashboards depend on the state property before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the three plugins and the general problem, validation errors. The changeset makes paging schema fixes in UniFi (five data streams), a paging fix in Steam, and a region mapping fix in W…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Pr Template
The PR changes three existing plugins (UniFi, Steam, WasabiWACM), so the "Change to an existing plugin" template applies. The repository template at .github/PULL_REQUEST_TEMPLATE/Change to an existing…
Full details: Title check
Explanation
The title names the three plugins and the general problem, validation errors. The changeset makes paging schema fixes in UniFi (five data streams), a paging fix in Steam, and a region mapping fix in WasabiWACM, so the title covers the main change at a general level without naming the specific fixes.
Full details: Pr Template
Explanation
The PR changes three existing plugins (UniFi, Steam, WasabiWACM), so the "Change to an existing plugin" template applies. The repository template at .github/PULL_REQUEST_TEMPLATE/Change to an existing plugin.md lists these headings: Summary, Related issue(s), Plugin details, Testing, Breaking changes, Documentation and Checklist. The PR body contains each of them, with the same emoji prefixes. The Testing section has real content: it describes a DEV deployment of WasabiWACM with demo data and five successful import steps, and it states that UniFi and Steam were not run against live accounts. The body is not free text and is not the template picker from .github/pull_request_template.md. The unchecked "single plugin only" checklist item does not affect this check. No extra sections were added, and none were needed. The Miscellaneous change template is not relevant, because files under plugins/ change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Automatic approval policy
Commit: 29d8eff41551.
Setting
Effective value
Source
Automatic approvals
Enabled
Global configuration
Merge risk
Low
Global configuration
Security risk
Not set
Global configuration
No overrides matched. The global limits apply.
Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
These three were left out of phase 2 because they failed validation on
main. That's fixed now (#200), so their classic tiles are converted with
the same converter and each gets a patch bump.
Six of their tiles stay classic: UniFi "Hosts" and Steam "Game News"
are status blocks with no state column, which a SmartViz status grid
can't draw, and WasabiWACM's four Properties tables show only columns
the stream doesn't declare.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DsSxB9yhNwiJp2KU2D8Upi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR fixes three plugins that fail
squaredup validateonmainagainst the current plugin schema. That keeps them out of the SmartViz conversion (#199), and their next deploy would fail too.pagingConfig_mode,pagingConfig_offset_base), which the schema no longer accepts. They all mean "no paging", so they now use"paging": { "mode": "none" }, as every other plugin does.gameNewsstream declares an empty"paging": {}with no mode. It now says"none"too.state, which the graph reserves. That fails the import, and DEV now refuses to deploy the plugin at all ("Invalid import definitions"). The property is nowregion, read from the samestatecolumn, as the build-plugin guidance suggests for an address.Note
This PR changes 3 plugins, so the single-plugin CI check will fail. An admin will need to override it, as for the SmartViz waves.
🔗 Related issue(s)
🧩 Plugin details
🧪 Testing
squaredup validatenow passes for all three plugins; onmainall three fail.WasabiWACM: I deployed the fixed version to a DEV organization with demo data and re-indexed it. All five import steps succeed, including the three that map
region. Themainversion can't be deployed to DEV at all.UniFi and Steam: the change only restates "no paging" in the current format, so requests are unchanged. I haven't run them against live UniFi or Steam accounts.
Does this PR introduce any breaking changes?
WasabiWACM's control, channel and sub-account objects get a new
regionproperty; their IDs, names and types don't change, so dashboards, scopes and perspectives keep working. The graph only accepts a health value (success,info,warning,error,unknown) instate, so an address state never reached any object: an account with one failed the import instead. Nothing can rely on the old mapping. Organizations whose accounts have a state will now import those objects where the import failed before.📚 Documentation
✅ Checklist
Generated by Claude Code
Summary by CodeRabbit