Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMQrQZP9s7AUj6iNXZ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMQrQZP9s7AUj6iNXZ
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
This PR documents how stores treat class instances, which solidjs/solid#5031 makes official, and a frozen-object change that already shipped:
MapandDateonly.{ shallow: true }is how to keep a value raw. Also adds the getter and method rule.Merge timing: the frozen-object lines match
solid-js2.0.1. The class getter and method lines describe solidjs/solid#5031, so this PR should merge once that one lands.Checks:
lint-tonereports 0 errors (its 1 warning is onaction.mdx, not in this diff).check-examplespasses for the changed pages, checked against a solid build with #5031; its one error is a pre-existingimport.meta.enverror in the router setup page. Prettier is applied.Related issues & labels
Generated by Claude Code