Skip to content

Stop network volume pagination when a page marker repeats - #750

Open
cloudgpuapp wants to merge 2 commits into
runpod:mainfrom
cloudgpuapp:fix/volume-pagination-cycle
Open

cloudgpuapp wants to merge 2 commits into
runpod:mainfrom
cloudgpuapp:fix/volume-pagination-cycle

Conversation

@cloudgpuapp

Copy link
Copy Markdown

Summary

  • Stop a network volume listing when any previously seen page marker returns. The existing check catches immediately repeated markers but misses a cycle spanning multiple pages.
  • Preserve the existing resumable pagination error for callers and add a regression test with an in-process S3 fixture.

This hardens the Python client's handling of inconsistent pagination. It does not change the S3 endpoint or resolve the service-side behavior reported in #505.

Validation

  • Regression reproduced on ddd8972 before the fix. The fixture reached an unexpected fourth request.
  • All 141 tests in tests/test_network_volume_transfer.py passed on Python 3.12.
  • The production file passes Black and the patch passes git diff --check. The test file has the same pre-existing Black differences as the baseline.
  • No live S3 or GPU resources were used for the pagination regression.

AI assistance was used to develop and test this change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-22T01:08:45.088562Z 4d21daf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant