Skip to content

fix(apps): reject nested requirements files during build - #748

Open
cloudgpuapp wants to merge 1 commit into
runpod:mainfrom
cloudgpuapp:fix/reject-nested-requirements
Open

cloudgpuapp wants to merge 1 commit into
runpod:mainfrom
cloudgpuapp:fix/reject-nested-requirements

Conversation

@cloudgpuapp

Copy link
Copy Markdown

Summary

Flash deploy silently skips nested requirements directives in requirements.txt, which can produce an artifact missing dependencies. Reject -r and --requirement directives with a file-and-line diagnostic and tell users to list those dependencies directly.

Addresses the nested requirements case reported in #721. #722 covers the separate inline-comment case.

Tests

  • Four regression cases fail on the upstream baseline and pass with this change.
  • 209 tests passed across the build, deploy, and deployment validation suites on Python 3.12. No cloud deployment was run.

AI assistance was used to prepare and test this change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T21:24:05.846090Z fe842fe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant