Skip to content

fix(apps): validate all volume placements before provisioning - #738

Merged
KAJdev merged 6 commits into
mainfrom
zeke/con-2178-flash-20-g-022-datacenterus_ks_2-rejected-for
Nov 20, 2026
Merged

KAJdev merged 6 commits into
mainfrom
zeke/con-2178-flash-20-g-022-datacenterus_ks_2-rejected-for

Conversation

@KAJdev

@KAJdev KAJdev commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Deploying an App with multiple volumes could create one volume before discovering that another cannot be placed. For example, a volume pinned to EU-RO-1 followed by one pinned to US-KS-2 fails before either is created when the catalog reports that US-KS-2 lacks network volume support. Deploy, dev startup, dev refresh, and task provisioning validate the referenced volumes and their shared resource constraints before creating storage.

The DataCenter enum includes all 22 volume-capable datacenters in the current catalog, including DataCenter.AP_IN_1, DataCenter.AP_JP_1, and DataCenter.EU_SE_1. Volume creation support is checked against the live catalog, since a datacenter can support compute without supporting network volumes.

Fixes CON-2178

@KAJdev
KAJdev requested review from deanq and justinwlin November 20, 2026 18:20
@justinwlin

justinwlin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Kimi review posted: #738 (review)

How to ask for a Kimi review: GitHub: request @justinwlin as a reviewer, or comment @justinwlin watcher, review on the PR. Slack: DM @justin.lin Watcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM Watcher, stop <PR link>.

@justinwlin justinwlin left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimi review, round 1

Verdict: Approved. 0 Critical, 0 High, 1 Medium+Low → approved.

Context: Volume creation is now deferred until deploy, dev, reconciliation, and task preflight has planned every volume against catalog support and shared resource placement constraints. The datacenter enum also covers the 22 volume-capable locations cited by the PR.

Next step: @KAJdev merges; finding 1 is a non-blocking follow-up.

Findings

  1. Medium: Shared volumes with conflicting create declarations remain order-dependent, so a later create=False can be ignored. runpod/apps/volume.py:350 (inline).
Other reviewers, PR description, nits, what was run
  • Ran: pytest -q --no-cov tests/test_apps/test_volume_preflight.py tests/test_apps/test_volume.py tests/test_apps/test_placement.py tests/test_apps/test_deploy.py tests/test_apps/test_dev.py tests/test_apps/test_deployed_tasks.py tests/test_apps/test_deployment_validation.py → 298 passed.
  • Reproduced finding 1 through normal reconcile_endpoints: one global-volume creation and two endpoint saves despite the second declaration using create=False.
  • CI: all 9 reported checks passed; branch protection reports no required checks.
  • PR body claim "all 22 volume-capable datacenters in the current catalog": enum mappings verified; live catalog not queried.

Kimi (moonshotai/Kimi-K3.1-Pro) · round 1 · 3 review agents (resolver correctness, deploy/dev integration, tests/PR claims) · 6 min · automated review, a human owns the final call. New commits are checked every 5 min and get an automatic re-review of the changes since this round. Ask for a review: request @justinwlin as a reviewer, comment @justinwlin watcher, review on the PR, or Slack DM @justin.lin Watcher, review <PR link>. Stop re-reviews: Slack DM Watcher, stop <PR link>.

Comment thread runpod/apps/volume.py Resolved
@KAJdev
KAJdev requested a review from justinwlin November 20, 2026 18:49
@justinwlin

justinwlin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Kimi review posted: #738 (review)

How to ask for a Kimi review: GitHub: request @justinwlin as a reviewer, or comment @justinwlin watcher, review on the PR. Slack: DM @justin.lin Watcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM Watcher, stop <PR link>.

@justinwlin justinwlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimi review, round 2

Verdict: Approved. 0 Critical, 0 High, 0 Medium+Low → approved. Round 1 approval stands.

Context: This PR preflights volume placement before storage provisioning. The new commit also combines create across every declaration of a shared volume, making create=False effective regardless of resource order.

Next step: @KAJdev merges.

Status of prior findings

# Finding Severity Status Evidence
R1-1 A later shared-volume create=False declaration could be ignored. Medium Fixed at 1537785 runpod/apps/volume.py:363-369 aggregates every declaration; both missing-volume paths enforce the combined value at runpod/apps/volume.py:381-386 and runpod/apps/volume.py:396-397.

No new findings since 4dde5c3.

Other reviewers, PR description, nits, what was run
  • Ran: pytest -q --no-cov tests/test_apps/test_volume_preflight.py → 63 passed; pytest -q --no-cov tests/test_apps/test_volume.py tests/test_apps/test_placement.py tests/test_apps/test_deploy.py tests/test_apps/test_dev.py tests/test_apps/test_deployed_tasks.py tests/test_apps/test_deployment_validation.py → 247 passed.
  • CI: CodeQL and e2e passed; five Python-version jobs were still pending at review time. Branch protection reports no required checks.
  • PR body datacenter mappings and catalog-based placement behavior verified in code and tests; the live catalog was not queried.

Kimi (moonshotai/Kimi-K3.1-Pro) · round 2 · 2 review agents (resolver correctness/existing feedback, tests/integration) · 4 min · automated review, a human owns the final call. New commits are checked every 5 min and get an automatic re-review of the changes since this round. Ask for a review: request @justinwlin as a reviewer, comment @justinwlin watcher, review on the PR, or Slack DM @justin.lin Watcher, review <PR link>. Stop re-reviews: Slack DM Watcher, stop <PR link>.

Comment thread runpod/apps/volume.py Resolved
Comment thread runpod/apps/datacenter.py Resolved
Comment thread runpod/apps/datacenter.py Resolved
@KAJdev
KAJdev requested review from deanq and justinwlin November 20, 2026 20:19
@justinwlin

justinwlin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Kimi review posted: #738 (review)

How to ask for a Kimi review: GitHub: request @​justinwlin as a reviewer, or comment @​justinwlin w​atcher, review on the PR. Slack: DM @​justin.lin W​atcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM W​atcher, stop <PR link>.

@justinwlin justinwlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimi review, round 3

Verdict: Approved. 0 Critical, 0 High, 0 Medium+Low → approved. Round 1 approval stands.

Context: This PR preflights volume placement before storage provisioning. The new commit limits task-launch checks to that task's volumes and preserves the previous eleven-location default compute pool while allowing explicit placement elsewhere.

Next step: KAJdev merges.

Status of prior findings

# Finding Severity Status Evidence
R1-1 A later shared-volume create=False declaration could be ignored. Medium Fixed at 1537785; remains fixed runpod/apps/volume.py:372-406 aggregates every declaration and enforces the combined value in both missing-volume paths.

No new findings since 1537785.

Other reviewers, PR description, what was run
  • Ran: pytest -q --no-cov tests/test_apps/test_volume_preflight.py tests/test_apps/test_datacenter_defaults.py tests/test_apps/test_volume.py tests/test_apps/test_placement.py tests/test_apps/test_deploy.py tests/test_apps/test_dev.py tests/test_apps/test_deployed_tasks.py tests/test_apps/test_deployment_validation.py → 340 passed.
  • deanq on runpod/apps/volume.py:514: Verified fixed at 2f42875; task preflight is scoped to the task's volume keys while retaining shared constraints. Thread
  • deanq on runpod/apps/datacenter.py:40: Verified fixed at 2f42875; the prior compute defaults are separate from the expanded volume catalog enum. Thread
  • deanq on runpod/apps/datacenter.py:41: Verified fixed at 2f42875; AP entries have their own section. Thread
  • CI: CodeQL and e2e passed; five Python-version jobs were still pending at review time. Branch protection reports no required checks.
  • PR body datacenter mappings and preflight behavior verified in code and tests; the live catalog was not queried.

Kimi (moonshotai/Kimi-K3.1-Pro) · round 3 · 2 review agents (placement/task correctness, tests/existing feedback) · 4 min · automated review, a human owns the final call. New commits are checked every 5 min and get an automatic re-review of the changes since this round. How to ask for a Kimi review: GitHub: request @​justinwlin as a reviewer, or comment @​justinwlin w​atcher, review on the PR. Slack: DM @​justin.lin W​atcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM W​atcher, stop <PR link>.

Comment thread tests/test_apps/test_cpu_datacenter.py Resolved
@KAJdev
KAJdev requested review from deanq and justinwlin November 20, 2026 22:01
@justinwlin

justinwlin commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Kimi review posted: #738 (review)

How to ask for a Kimi review: GitHub: request @​justinwlin as a reviewer, or comment @​justinwlin w​atcher, review on the PR. Slack: DM @​justin.lin W​atcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM W​atcher, stop <PR link>.

@justinwlin justinwlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kimi review, round 4

Verdict: Approved. 0 Critical, 0 High, 0 Medium+Low → approved. Round 1 approval stands.

Context: This PR preflights volume placement before storage provisioning. The new commit restores backend pass-through for explicit cpu5 pins outside the original default pool while retaining early rejection for unsupported configurations wholly within that pool.

Next step: KAJdev merges.

Status of prior findings

# Finding Severity Status Evidence
R1-1 A later shared-volume create=False declaration could be ignored. Medium Fixed at 1537785; remains fixed runpod/apps/volume.py:372-406 aggregates and enforces every declaration.

No new findings since 2f42875.

Other reviewers, PR description, what was run
  • Ran: pytest -q --no-cov tests/test_apps/test_cpu_datacenter.py tests/test_apps/test_datacenter_defaults.py tests/test_apps/test_volume_preflight.py tests/test_apps/test_volume.py tests/test_apps/test_placement.py tests/test_apps/test_deploy.py tests/test_apps/test_dev.py tests/test_apps/test_deployed_tasks.py tests/test_apps/test_deployment_validation.py → 604 passed.
  • deanq on tests/test_apps/test_cpu_datacenter.py:17: Verified fixed at 7fe2344; cpu5 pins outside the default pool pass through, with normalized, mixed-pin, payload, and placement coverage. Thread
  • CI: CodeQL and e2e passed; five Python-version jobs were pending at review time. Branch protection reports no required checks.
  • PR body datacenter mappings and preflight behavior verified in code and tests; the live catalog was not queried.

Kimi (moonshotai/Kimi-K3.1-Pro) · round 4 · 2 review agents (correctness/existing feedback, tests/PR claims) · 4 min · automated review, a human owns the final call. New commits are checked every 5 min and get an automatic re-review of the changes since this round. How to ask for a Kimi review: GitHub: request @​justinwlin as a reviewer, or comment @​justinwlin w​atcher, review on the PR. Slack: DM @​justin.lin W​atcher, review <PR link>. New commits get an automatic re-review (checked every 5 min). Stop it: DM W​atcher, stop <PR link>.

@KAJdev
KAJdev merged commit ddd8972 into main Nov 20, 2026
9 checks passed
@KAJdev
KAJdev deleted the zeke/con-2178-flash-20-g-022-datacenterus_ks_2-rejected-for branch November 20, 2026 22:47
@promptless

promptless Bot commented Nov 20, 2026

Copy link
Copy Markdown

Promptless documentation updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants