Repository navigation
Add package write permissions to docker.yaml workflow - #664
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — the sdk-test-docker job authenticates to ghcr.io with secrets.GITHUB_TOKEN and pushes test-services-java images, so it needs packages: write. Scoping it at the job level with contents: read gives it least privilege.
Reviewed changes
I reviewed the single-commit change to .github/workflows/docker.yaml.
- Job permissions: adds
contents: readandpackages: writetosdk-test-docker. These cover everything the job does:actions/checkout, thendocker/login-actionplusdocker push. The setup actions' caches use the Actions runtime token, notGITHUB_TOKENscopes, so they don't need anything more. - Whitespace cleanup: removes trailing spaces from the
on:trigger lines. This doesn't change behavior.
claude-opus-5-5 | 𝕏
Contributor
Test Results 8 files ±0 8 suites ±0 3m 47s ⏱️ -9s Results for commit 4899e79. ± Comparison against base commit dfeaa8e. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add package write permissions to docker.yaml workflow.