Skip to content

Add package write permissions to docker.yaml workflow - #664

Merged
tillrohrmann merged 1 commit into
mainfrom
fix-permissions
Nov 18, 2026
Merged

tillrohrmann merged 1 commit into
mainfrom
fix-permissions

Conversation

@tillrohrmann

Copy link
Copy Markdown
Contributor

Add package write permissions to docker.yaml workflow.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — the sdk-test-docker job authenticates to ghcr.io with secrets.GITHUB_TOKEN and pushes test-services-java images, so it needs packages: write. Scoping it at the job level with contents: read gives it least privilege.

Reviewed changes

I reviewed the single-commit change to .github/workflows/docker.yaml.

  • Job permissions: adds contents: read and packages: write to sdk-test-docker. These cover everything the job does: actions/checkout, then docker/login-action plus docker push. The setup actions' caches use the Actions runtime token, not GITHUB_TOKEN scopes, so they don't need anything more.
  • Whitespace cleanup: removes trailing spaces from the on: trigger lines. This doesn't change behavior.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

  8 files  ±0    8 suites  ±0   3m 47s ⏱️ -9s
 59 tests  - 1   59 ✅  - 1  0 💤 ±0  0 ❌ ±0 
266 runs   - 1  266 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 4899e79. ± Comparison against base commit dfeaa8e.

This pull request removes 1 test.
dev.restate.sdktesting.tests.ServiceToServiceScopeConcurrency ‑ scopeAndLimitKeyArePropagatedOnServiceToServiceCalls(URI, ContainerHandle, Client)

♻️ This comment has been updated with latest results.

@tillrohrmann
tillrohrmann merged commit 39c4ffa into main Nov 18, 2026
10 checks passed
@tillrohrmann
tillrohrmann deleted the fix-permissions branch November 18, 2026 19:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant