Repository navigation
Use the standard library and Location in the parser instead of ext - #9364
Conversation
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Use the standard library and Location in the parser instead of ext20e017c · cknitt + Claude · Nov 20, 2026, 22:14 UTC The parser library used a few ext helpers directly: Ext_list.map, filter_map and fold_left, which are List functions, two small identifier checks from Ext_ident, and Warnings.loc as a type annotation. It now uses List, its own copies of the two checks in Res_scanner, and Location.t, which is the same type. The parser reaches ext only through Location now. Ext_ident.is_uident had no other user and is removed. |
✅ Compiler benchmarksAllocated wordsIn total: 636,553,281 → 636,553,614 (±0.00%). Generated projects: 629,021,630 → 629,021,532 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,222,593,576 → 9,223,228,868 (+0.01%).
Output sizeIn total: 25,969,533 → 25,969,532 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 20e017c compared with base 770e3dd in this run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## parser-warnings-as-values #9364 +/- ##
==========================================================
Coverage 82.19% 82.20%
==========================================================
Files 462 462
Lines 65761 65763 +2
==========================================================
+ Hits 54055 54058 +3
+ Misses 11706 11705 -1
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The parser library used a few ext helpers directly: Ext_list.map, filter_map and fold_left, which are List functions, two small identifier checks from Ext_ident, and Warnings.loc as a type annotation. It now uses List, its own copies of the two checks in Res_scanner, and Location.t, which is the same type. The parser reaches ext only through Location now. Ext_ident.is_uident had no other user and is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH Signed-off-by: Christoph Knittel <ck@cca.io>
853a66e to
20e017c
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Stacked on #9363. The parser library used a few
exthelpers directly. This PR replaces them, so the parser reachesextonly throughLocation, which a later step splits.Ext_list.map,filter_mapandfold_leftbecomeList.map,List.filter_mapandList.fold_left. Both visit elements left to right, so nothing changes. Three lambdas get a type annotation, since the lambda now comes before the list.Ext_ident.is_uidentandExt_ident.unwrap_uppercase_exotic, two small checks for quoted identifiers like\"Name".Ext_ident.is_uidenthad no other user and is removed;unwrap_uppercase_exoticstays, the code generator and gentype use it.Warnings.loctype annotations becomeLocation.t, which is the same type.🤖 Generated with Claude Code
https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH