Repository navigation
Move the compiler-only dict and error helpers out of the AST library - #9360
Conversation
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Move the compiler-only dict and error helpers out of the AST library36af448 · cknitt + Claude · Nov 20, 2026, 21:21 UTC The AST library had code that only the compiler uses. The v0 PPX encoding of dict literals moves from Ast_dict to a new compiler module, Ast_dict0, so the AST library no longer needs Primitive_modules. Ast_mapper's extension_of_error and Ast_raw's uninterpreted error move to Builtin_attributes, next to error_of_extension, which decodes such errors. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ast-payload-to-ml #9360 +/- ##
==================================================
Coverage 82.19% 82.19%
==================================================
Files 459 460 +1
Lines 65739 65744 +5
==================================================
+ Hits 54031 54036 +5
Misses 11708 11708
🚀 New features to boost your workflow:
|
✅ Compiler benchmarksAllocated wordsIn total: 636,535,682 → 636,535,399 (±0.00%). Generated projects: 629,007,535 → 629,006,927 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,224,520,504 → 9,222,857,528 (-0.02%).
5 more changes
Output sizeIn total: 25,969,643 → 25,969,547 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 36af448 compared with base 4571994 in this run. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The AST library had code that only the compiler uses. The v0 PPX encoding of dict literals moves from Ast_dict to a new compiler module, Ast_dict0, so the AST library no longer needs Primitive_modules. Ast_mapper's extension_of_error and Ast_raw's uninterpreted error move to Builtin_attributes, next to error_of_extension, which decodes such errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH Signed-off-by: Christoph Knittel <ck@cca.io>
2bd0df9 to
36af448
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Stacked on #9359. Moves code that only the compiler uses out of the AST library (
compiler/ast), so the library no longer needsPrimitive_modules.Primitive_dict.make/spreadcalls with theres.dict*markers) moves fromAst_dictto a new compiler module,Ast_dict0, used by the v0 AST bridge.Ast_dictkeeps the grouping of dict entries that the parser, printer and type checker use.Ast_mapper.extension_of_errorandAst_raw.uninterpretedbuild compiler errors. They move toBuiltin_attributesasextension_of_erroranduninterpreted_extension, next toerror_of_extension, which decodes such errors and now reuses the same message.The AST library now reaches 9
extmodules, all throughLocationandClflags.🤖 Generated with Claude Code
https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH