Repository navigation
Conversation
Since 1.3.3 the popup renders its content in `.rc-tooltip-container` (it was `-inner` up to 1.2.2 and `-body` in 1.3.0 to 1.3.2), but `assets/bootstrap.less` and `assets/bootstrap_white.less` still style `.rc-tooltip-inner`. Anyone importing `assets/bootstrap.css` or `assets/bootstrap_white.css` gets a tooltip with no background, padding or text color. Rename the rule in both themes, and add a test that the stylesheets style the class the popup renders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@esetnik is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough两个 Bootstrap LESS 文件将提示框内容样式选择器从 Changes提示框样式选择器更新
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 38 38
Branches 15 15
=========================================
Hits 38 38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What
The bundled stylesheets no longer style the tooltip's content box.
Popuprenders the content in.rc-tooltip-container. It was.rc-tooltip-innerup to 1.2.2 and.rc-tooltip-bodyin 1.3.0–1.3.2, then #505 renamed it.assets/bootstrap.lessandassets/bootstrap_white.lessstill style.rc-tooltip-inner. So an app that imports@rc-component/tooltip/assets/bootstrap_white.css, as the README's usage example does (orbootstrap.css), gets a tooltip with no background, padding, text color or border radius. The published 1.5.2bootstrap.cssis byte-identical to the one inrc-tooltip6.4.0.Change
.@{tooltip-prefix-cls}-containerin both themes. The-arrow-innerrules of the white theme are a different element and are unchanged.tests/assets.test.tsx. It renders a tooltip, checks that therole="tooltip"element carriesrc-tooltip-container, and checks that both.lessfiles style that class and no longer style-inner. It fails onmaster.Checks
npm test: 33 passed. The new test fails without the change.npm run tscand ESLint are clean.lessc assets/bootstrap.lessemits the.rc-tooltip-containerrule.🤖 Generated with Claude Code
Summary by CodeRabbit