Repository navigation
Conversation
Member
Author
|
CC @zware |
zware
reviewed
Nov 20, 2026
|
|
||
| def _refresh_branch_info(self): | ||
| with urllib.request.urlopen(BRANCHES_URL) as file: | ||
| with urllib.request.urlopen(BRANCHES_URL, timeout=10) as file: |
Member
There was a problem hiding this comment.
This seems excessive; I'd be surprised if a real request with no external issues took more than 1s :). What happens if we hit timeout?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard fetches release data without a timeout, which I found during review of the failed refresh below. Limit the request to two seconds and reuse the previous branch data if it fails. Return 503 when no branch data exists yet so the caller can retry.