Repository navigation
Wait for the HTTP response in the PR reporter - #835
Merged
Merged
Conversation
Member
Author
|
CC @zware |
zware
approved these changes
Nov 20, 2026
zware
left a comment
Member
There was a problem hiding this comment.
The actual change looks fine and I'm on board with adding proper testing. A couple of quibbles on how to trigger the tests, and the content of the test itself.
| self.assertNoResult(result) | ||
| response = mock.Mock(code=201) | ||
| pending.callback(response) | ||
| self.assertIs(self.successResultOf(result), response) |
Member
There was a problem hiding this comment.
TBH, there's so much mocking here that I'm not sure how useful this is as a test.
| - name: Check configuration | ||
| run: make check PIP=pip BUILDBOT=buildbot PYTHON_VERSION=${{ matrix.python-version }} | ||
| - name: Check custom components | ||
| run: PYTHONPATH=master python -m unittest discover -s tests |
Member
There was a problem hiding this comment.
Can we fold this into make check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that posts build failures to GitHub returns before the HTTP request is complete. The caller then treats the unfinished request as a response and fails with the error below. Wait for the POST request to finish before the reporter returns its response.