Repository navigation
Fix slice step offsets and empty bounds - #505
Merged
martindurant merged 2 commits intoNov 17, 2026
Merged
Conversation
Member
|
Apparently the CI setup needs to be refreshed. |
Contributor
Author
|
Thanks @martindurant. Updated CI to install Miniforge explicitly with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream.slice(1, None, 2)currently emits items at indices 2, 4, 6 instead of 1, 3, 5. It also treatsend=0as an unbounded slice.This counts the step from
startand handles zero as an explicit end. Two cases extend the existing slice test, one for each bug.The new cases fail on the original code. With the fix, the core suite passes with 125 passed and 2 skipped, and flake8 passes. Independent review also checked slicing boundaries, detachment and metadata reference counts. Other test modules were not run.
Prepared with AI assistance.