Skip to content

Remove release candidates from the plugin XML - #56

Merged
RomainLvr merged 1 commit into
mainfrom
fix/remove-rc-from-xml
Nov 20, 2026
Merged

RomainLvr merged 1 commit into
mainfrom
fix/remove-rc-from-xml

Conversation

@Lainow

@Lainow Lainow commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Description

The marketplace offers 1.0.0-rc2 as an update to instances running 1.0.0+glpi11.

GLPI compares plugin versions with PHP version_compare(), which does not follow semver: + is a plain separator and glpi is an unknown token, ranked below dev, alpha, beta and rc. So 1.0.0+glpi11 is considered lower than 1.0.0-rc1 and 1.0.0-rc2, and the highest available version for GLPI 11 becomes 1.0.0-rc2.

This PR removes the two release candidates from moreoptions.xml. 1.0.0+glpi11 is then the only GLPI 11 entry, so it is no longer seen as outdated.

@Lainow
Lainow requested a review from RomainLvr November 20, 2026 14:21
@Lainow Lainow self-assigned this Nov 20, 2026
@RomainLvr
RomainLvr merged commit 55aec1f into main Nov 20, 2026
5 of 7 checks passed
@RomainLvr
RomainLvr deleted the fix/remove-rc-from-xml branch November 20, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants