Skip to content

[ENG-4594] Stop telling hosted builders to add an API key before publishing - #507

Merged
mariojgt merged 2 commits into
mainfrom
eng-4594-no-api-key-ask
Nov 20, 2026
Merged

mariojgt merged 2 commits into
mainfrom
eng-4594-no-api-key-ask

Conversation

@mariojgt

Copy link
Copy Markdown
Contributor

Closes ENG-4594

What changed

Connect no longer tells anyone in a hosted builder to add an API key, and no longer presents the key as required anywhere.

  • go-live in Replit and Bolt is now one step, the builder's own publish button, with "There is no key to add." Lovable already worked this way.
  • Bolt is a host go-live knows, found from the project's .bolt directory or named with --host bolt.
  • The next-step lines after setup no longer say "set PATCHSTACK_API_KEY on your host". They say to commit and deploy, and that no key is needed.
  • go-live with no host found no longer ends on "Add PATCHSTACK_API_KEY to its environment variables". It says to deploy as usual, and that adding the key on a self-managed host is optional.
  • On hosts that take a key (Vercel, Netlify and the rest), the step stays but reads as optional: "Your live app gets protection rules without it; with the key, what it reports is verified."
  • go-live needs .patchstackrc.local.json only when its steps read the key from it. A builder's workspace may not keep that file, and its steps never use it.
  • AGENT-INSTALL.md says outright never to ask the person for an API key or a token, and why none is needed to publish.

Why

A published app carries a read-only credential in its guard's rules file, which is enough to fetch protection rules. The full key is optional. But the CLI's own output still told people to add it:

  • In Replit, go-live said "open Secrets and add PATCHSTACK_API_KEY".
  • Bolt was not recognised, so it got the generic "add it to your environment variables" line.
  • The summary's next step said "set PATCHSTACK_API_KEY on your host".

An assistant relays those lines, so the builder stopped and asked the person for a key they have never been shown. The package's own agent guide already said not to.

Verified

  • tests/go-live.test.ts: Lovable, Replit and Bolt print no PATCHSTACK_API_KEY, "Secrets" or "environment variables"; .bolt is detected; the key file is required only for hosts whose steps read it.
  • Ran the built CLI in an empty project: go-live with a .bolt directory, --host replit, no host, and --host vercel (which still asks for setup first).
  • npm run typecheck, npm run build and capabilities:check are green. Full npm test: 4756 passed, 7 skipped.

Outstanding

AGENT-INSTALL.md and the checklist's next-step text ship in the tarball, so they cannot be field-tested before release. The hostile run is owed right after the release that carries this.

Not changed

Hosted-builder detection for the environment label and for the missing-key messages still knows Lovable and Replit only. Adding Bolt there would also change how its builds are labelled, which needs its own check.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderbuds

coderbuds Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🎯 Elite quality (93%) — Consistently removes API-key requirement for hosted builders, with a clean BUILDER_PUBLISH map driving go-live behavior.

📦 Medium

🤖 Written by Claude Code — going by its own attribution. Unknown whether a person read it; agents can report that with the report-ai-usage-tool tool.

🔴 High risk — changes claude-plugin/skills/next/SKILL.md, which a person always reads.

✅ Reviewed — approved by @daniloradovic.

See how your team is trending →

@mariojgt

Copy link
Copy Markdown
Contributor Author

/review

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@mariojgt
mariojgt merged commit b1f8457 into main Nov 20, 2026
28 checks passed
@mariojgt
mariojgt deleted the eng-4594-no-api-key-ask branch November 20, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants