Repository navigation
Conversation
…in rules - the guard's status reports delivered and built-in rule counts - the runtime check prints them as 'N rules from Patchstack + M built into the guard' - 'map-scoped rules' is now 'rules for this app's own routes' - setup's rule lookup line says the delivered rules sit on top of the built-in ones
|
🎯 Elite quality (96%) — Clarifies rule-count wording by splitting delivered and local rules, with matching runtime, CLI and report updates. 📦 Small 🟠 Elevated risk — the author's first change to this repository. ✅ Reviewed — approved by @daniloradovic. |
…e from - the runtime check's split includes outgoing rules, so it adds up to the two totals - rules are 'from Patchstack' only when fetched; otherwise 'from its bundled rules file' - the guard's own rules count is 'local', which also covers rules the host configures - setup and the summary say 'protection rules from Patchstack' instead of 'available' - setup does not mention the guard for an app with no server - one rule is 'rule', not 'rules'
Author
|
/review |
daniloradovic
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-4600 (the Connect part; the widget change is patchstack/sass-webvdp-widget#198)
Setup said 17 rules and the runtime check said 26. Both were right, but they counted different things, and nothing said so. 17 is what Patchstack delivered. 26 also includes the guard's own response rules, and left out outgoing rules.
synchronization.rulesnow hasdelivered(from Patchstack, or the bundled rules file when the lookup failed) andlocal(the guard's own response and outgoing rules, including any the host configures).request,responseandegresscount both, so they add up to the two.AGENT-INSTALL.mdshows the summary line, so its example changes too. That file is audited from the published tarball, so the hostile field run (node field-test/run.mjs --persona hostile --rounds 3) is still outstanding and has to run after the release that carries this.Tests:
npm testpasses (4753). New tests check that the counts add up, the wording for fetched and bundled rules, the singular, and the older-guard fallback.