Skip to content

[ENG-4589] Make status and setup summary output clearer - #505

Open
terdelyi wants to merge 3 commits into
mainfrom
tamase/eng-4589-connect-cli-output-confuses-the-person
Open

terdelyi wants to merge 3 commits into
mainfrom
tamase/eng-4589-connect-cli-output-confuses-the-person

Conversation

@terdelyi

@terdelyi terdelyi commented Nov 19, 2026 •

Copy link
Copy Markdown

Closes ENG-4589

Several lines that Connect prints, and that an assistant passes on to the person, were unclear or wrong.

status

  • It printed the claim page as "Dashboard URL" whatever the site's state. Now it labels the same link "Connect link" while the site has no owner, and "Dashboard link" once it has one. A signed-in owner who opens the claim page lands on the site.
  • No link for a site Patchstack reports as removed, or for an endpoint that only a committed .patchstackrc.json names. Other commands already hide the link in that second case.
  • "Environment: local" read as the state of the live app. A local or sandbox label now says it is where the command runs, not the live app. A production label is printed as it is.
  • The claim and site-status checks run in parallel, so an unreachable Patchstack costs one timeout, not two.

Guard during next build

  • next build loads route modules to prerender them and refuses their network requests, so the guard printed "the guard's rules are not current". That guard serves no traffic, and the running server builds its own. The warning is now skipped when NEXT_PHASE is phase-production-build. Next.js sets this before it starts the build workers, and the workers inherit it.

Setup summary

  • The deploy step said "Run: npx @patchstack/connect go-live … When that's done, say done." The person cannot tell whether to run it. It now says "Say done to get the steps for your host." next already answers "done" with those steps.
  • "Refresh your app's preview" is now "Reload your app's preview page … on it". The widget command uses the same wording.

AGENT-INSTALL.md describes the summary and status, so it changes with them, as do the status lines in GETTING-STARTED.md and README.md. That file is audited from the published tarball, so the hostile field run (node field-test/run.mjs --persona hostile --rounds 3) is still outstanding and has to run after the release that carries this.

Tests: npm test passes (4758). New tests cover the status output (no owner, connected, unverifiable, removed, untrusted endpoint, production label), the quiet warning during next build, and the deploy step in the summary.

… reading it

- status labels the claim link as a connect link and shows it only while the site has no owner
- status says its environment is the machine running the command, not the live app
- the guard no longer warns about stale rules while next build prerenders
- the summary's deploy step asks the person to say done instead of naming a CLI command
- the widget reload line says which page to reload
@coderbuds

coderbuds Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🎯 Elite quality (90%) — Clarifies status and setup summary wording with thorough end-to-end status tests and a parallelized fetch.

📦 Medium

🟠 Elevated risk — the author's first change to this repository.

✅ Reviewed — approved by @daniloradovic.

See how your team is trending →

- status prints the claim link for connected sites too, labelled as the dashboard link
- no link for a removed site or an endpoint only a committed file names
- the environment note is left off a production label
- status checks the claim state and site status in parallel
- AGENT-INSTALL.md, GETTING-STARTED.md and README.md describe the link status prints
- the deploy-step rule in AGENT-INSTALL.md names the exact lines to replace
- the widget command uses the same reload wording as the summary
- the NEXT_PHASE test stub is cleared in afterEach
@terdelyi

Copy link
Copy Markdown
Author

/review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants