Repository navigation
[ENG-4592] Keep the API key file out of a Vercel CLI deploy - #501
Merged
daniloradovic merged 1 commit intoNov 20, 2026
Merged
daniloradovic merged 1 commit into
daniloradovic merged 1 commit into
Conversation
`go-live` on Vercel tells the person to run `npx vercel --prod`. The Vercel CLI uploads the project folder, reads `.vercelignore` rather than `.gitignore`, and its default ignore list does not cover `.patchstackrc.local.json`, so the API key was uploaded with the deploy. `go-live` now adds `.patchstackrc.local.json` to `.vercelignore` when the host is Vercel (creating the file if needed, never adding the line twice) and says so. If it cannot, it says why and asks the person to add it. `next` only reads, so its Vercel steps ask for the line instead. The printed `vercel env add` command now uses `--environment production`, the syntax the Vercel CLI documents. The CLI help, README, AGENT-INSTALL.md and the Claude plugin's `next` skill now say that `go-live` writes this one entry on Vercel. Amp-Thread-ID: https://ampcode.com/threads/T-2e659ca3-7bd0-4d70-b3d3-09638251060b Co-authored-by: Danilo Radovic <danilo@patchstack.com>
|
🎯 Elite quality (96%) — Closes a real credential-upload gap on Vercel by reusing the existing ignore helper, with thorough tests. 📦 Medium 🤖 Written by Amp — going by its own attribution. Unknown whether a person read it; agents can report that with the 🔴 High risk — changes ✅ Reviewed — approved by @mariojgt. |
Contributor
Author
|
/review |
mariojgt
approved these changes
Nov 20, 2026
daniloradovic
deleted the
danilo/eng-4592-go-live-on-vercel-can-upload-the-local-api
branch
November 20, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-4592
What changed
go-liveadds.patchstackrc.local.jsonto.vercelignore. It creates the file if it is missing, appends without touching existing lines, never adds the line twice, and says what it did. If the write fails, it says why and asks the person to add the line.nextonly reads files, so its Vercel steps ask for the line instead of writing it.vercel env add PATCHSTACK_API_KEY --environment production --sensitive, the syntax the Vercel CLI documents (needs Vercel CLI 64.6.0+).nextskill now saygo-livewrites this one entry on Vercel.Why
go-livetells people to runnpx vercel --prod. The Vercel CLI uploads the project folder, reads.vercelignorerather than.gitignore, and its default ignore list does not cover.patchstackrc.local.json. So the file holding the API key was uploaded with the deploy.How it was verified
.vercelignorewriter (create, append, no duplicate, already listed,.gitignoreuntouched, write failure), the Vercel output lines, and a built-CLI run twice. They fail onmain.npm run typecheck,npm run build,npm run capabilities:check,npx vitest run(4759 passed, 7 skipped).