Repository navigation
[FSSDK-13474] Fix Arnica findings: artipacked workflows, MD5 hash, test class false positive - #412
Open
Esra Kartal (esrakartalOpt) wants to merge 2 commits into
Open
Esra Kartal (esrakartalOpt) wants to merge 2 commits into
Esra Kartal (esrakartalOpt) wants to merge 2 commits into
Conversation
…st class false positive - Add persist-credentials: false to the actions/checkout steps in ruby.yml and integration_test.yml so the GitHub token is not left in .git/config. - Use SHA256 instead of MD5 for the CMAB attributes cache fingerprint. - Add a nosemgrep comment on the TestBucketer test class (not a Rails model). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ubuntu-latest is now Ubuntu 26.04, which only provides the latest patch of each Ruby series, so exact versions like 3.1.0 fail in setup-ruby. Use 3.0, 3.1, 3.2 and 3.3 so the latest patch is always selected, and update the rubocop condition for Ruby 3.0 to match. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persist-credentials: falseto theactions/checkoutsteps in.github/workflows/ruby.yml(line 30) and.github/workflows/integration_test.yml(line 18), so the GitHub token is not left in.git/config(Arnica artipacked findings). No later step needs git credentials:ruby.ymlonly runs bundler, rubocop, rspec and coveralls, and theintegration_test.ymltrigger script passes its token tocurlthrough env vars and does not use git.Digest::MD5withDigest::SHA256inOptimizely::CmabService#hash_attributes(Arnica weak MD5 finding). The hash is only a local fingerprint used to check that cached CMAB attributes still match. It is never sent to the CMAB API or shared with other SDKs. After upgrading, an existing cached entry will simply mismatch once and trigger one fresh fetch.nosemgrepcomment onTestBucketerinspec/bucketing_holdout_spec.rb. The attr_accessible rule is for Rails models, and this is a plain test double, so the finding is a false positive. Arnica may need the finding dismissed with that reason if the comment is not honored.Test plan
bundle exec rake spec: 1131 examples, 0 failuresbundle exec rubocop: no offensesspec/cmab) pass with the new hashIssues
🤖 Generated with Claude Code