Skip to content

cmd/rofl: Add support for the proxy_protocol port annotation - #760

Merged
uniyalabhishek merged 1 commit into
masterfrom
uniyalabhishek/feature/rofl-proxy-protocol
Nov 20, 2026
Merged

uniyalabhishek merged 1 commit into
masterfrom
uniyalabhishek/feature/rofl-proxy-protocol

Conversation

@uniyalabhishek

@uniyalabhishek uniyalabhishek commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Implements CLI support for oasisprotocol/oasis-sdk#2516 (companion to oasisprotocol/oasis-sdk#2616).

Validates net.oasis.proxy.ports.<published_port>.proxy_protocol in compose.yaml (allowing only v2) and sets net.oasis.proxy.proxy_protocol to v2 in deployment metadata during oasis rofl deploy when any exposed TCP port enables it.

Release after rofl-scheduler and rofl-containers together with bumping the rofl-containers artifact, since older guest images cannot decode the new proxy_protocol label field when enabled.

@netlify

netlify Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 1b95dcf
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/6b000e72a9afc8ffdcea05c0

@matevz matevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference between v1 and v2 from the developer's point of view? IMO we can just make a switch and silently use v2 everywhere with the new scheduler/containers version.

@uniyalabhishek

Copy link
Copy Markdown
Contributor Author

Is there a difference between v1 and v2 from the developer's point of view? IMO we can just make a switch and silently use v2 everywhere with the new scheduler/containers version.

yes. v1 is text and v2 is binary, and the app's server must read the format we send. we also cannot turn it on everywhere, because an app that does not expect the header breaks. so it is opt-in per port, and the value says which format.

Comment thread cmd/rofl/build/validate.go Resolved
@uniyalabhishek
uniyalabhishek force-pushed the uniyalabhishek/feature/rofl-proxy-protocol branch from 0302555 to 1b95dcf Compare November 20, 2026 09:10
@uniyalabhishek
uniyalabhishek merged commit ee044c7 into master Nov 20, 2026
5 checks passed
@uniyalabhishek
uniyalabhishek deleted the uniyalabhishek/feature/rofl-proxy-protocol branch November 20, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants