Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## c_master #1233 +/- ##
============================================
+ Coverage 57.47% 63.73% +6.26%
============================================
Files 10 10
Lines 1124 1150 +26
Branches 129 142 +13
============================================
+ Hits 646 733 +87
+ Misses 478 417 -61 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msgpack_object_to_timestamp(include/msgpack/timestamp.h) returns true for a timestamp64/96 whose nanoseconds field is above the spec's 999999999.c7 0c ff ff ff ff ff ff ff ff ff ff ff ff ff(sec -1, nsec 0xffffffff) decodes totv_nsec = 4294967295, which becomes -1 once copied into astruct timespecwith a 32-bitlong, and passing the result back tomsgpack_pack_timestampsilently drops the top bits of any nsec at or above 2^30, since the timestamp64 path shiftstv_nsecleft by 34.Return false for those values, the result the function already gives for a malformed timestamp ext, and leave
tsuntouched in that case. This is the c_master half of #1227, which added the same check to the C++ timespec/chrono adaptors and can't reach the C library; the newtimestamp_nsec_out_of_rangetest fails on the current tree and passes with the fix, and the C suite stays green under ASan.