Repository navigation
Build and run the C tests on Windows CI - #1232
Merged
Merged
Conversation
MSGPACK_BUILD_TESTS defaults to OFF and neither appveyor.yml nor the GitHub Actions windows job turned it on, so ctest reported "No tests were found" and the C tests have never run on MSVC. Enable it, pass -C Release to ctest for the multi-config generator, build the gtest 1.7.0 DLL with the shared CRT, and pick the vcpkg triplet that matches the target architecture.
Link gtest statically: the DLL build needs GTEST_LINKED_AS_SHARED_LIBRARY, which makes the gtest 1.7.0 headers emit C4251/C4275 and fail under /WX. Guard the 64-bit-only zbuffer size tests with the preprocessor so their constants do not overflow on 32-bit targets (C4307).
redboltz
force-pushed
the
fix_appveyor_test
branch
from
November 20, 2026 13:56
a36c239 to
cebdcc7
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## c_master #1232 +/- ##
============================================
+ Coverage 57.47% 63.73% +6.26%
============================================
Files 10 10
Lines 1124 1150 +26
Branches 129 142 +13
============================================
+ Hits 646 733 +87
+ Misses 478 417 -61 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSGPACK_BUILD_TESTS defaults to OFF and neither appveyor.yml nor the GitHub Actions windows job turned it on, so ctest reported "No tests were found" and the C tests have never run on MSVC. Enable it, pass -C Release to ctest for the multi-config generator, build the gtest 1.7.0 DLL with the shared CRT, and pick the vcpkg triplet that matches the target architecture.