Repository navigation
Fix null pointer passed to memcpy/memcmp for empty str/bin objects. - #1231
Merged
Merged
Conversation
An empty str or bin decoded from the wire can carry a null data pointer. Copying such an object into another zone (msgpack::object(obj, zone)) called memcpy with a null source, and comparing it called memcmp with a null argument. Both are undefined behavior and are reported by UBSan. Skip the copy and the comparison when the size is zero.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1231 +/- ##
==============================================
- Coverage 85.36% 80.04% -5.33%
==============================================
Files 80 80
Lines 5099 5832 +733
Branches 507 645 +138
==============================================
+ Hits 4353 4668 +315
- Misses 746 1164 +418 🚀 New features to boost your workflow:
|
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty str or bin decoded from the wire can carry a null data pointer. Copying such an object into another zone (msgpack::object(obj, zone)) called memcpy with a null source, and comparing it called memcmp with a null argument. Both are undefined behavior and are reported by UBSan. Skip the copy and the comparison when the size is zero.