Repository navigation
chore: translate the client from the Node.js client line by line - #2067
Open
Yury Semikhatsky (yury-s) wants to merge 29 commits into
Open
Yury Semikhatsky (yury-s) wants to merge 29 commits into
Yury Semikhatsky (yury-s) wants to merge 29 commits into
Conversation
…ch, tracing and browser classes from the Node.js client
… waitForCondition, drop three fixmes
Serialization follows serializers.ts; Headers, StringUtils, MimeType, Time and LongStandingScope follow their isomorphic files; LocalUtils, ClientHelper and FileUtils are completed.
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
I'd tune the prompt a bit to keep as close to l2l as possible, even if that means that we are adding unused methods and implement features that were missing in the port.
Pavel Feldman (pavelfeldman)
approved these changes
Nov 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implis now a line-by-line translation of its file inpackages/playwright-core/src/client/(same member order, upstream names,// Port of <file>.ts.header,// java:notes where Java differs), so a roll applies the upstream diff at the same place. Includes the leaf classes of chore: port the leaf classes of the client from the Node.js client #2059.Serializationfollowsserializers.ts;Headers,StringUtils,MimeType,Time,LocatorUtilslive inimpl.isomorphic;LongStandingScope,LocalUtils,ClientHelper,FileUtilsfollow their upstream files;Utilskeeps only Java-specific helpers. Dead code is removed.Connect/JsonPipe(the connection pulls messages),UrlMatcher(globs are converted by the driver). The assertion classes are not retranslated yet.Behaviour that now follows upstream
connectOverCDPdefaults to a 30 s timeout (was 180 s).APIRequestContext.get/post/...always send their own method, even afterRequestOptions.setMethod.Response.finished()waits for the page to close when the request fails after its response;APIResponse.ok()is true for 200-299 only.Expected value of header "x" to be String, but "object" is found.route.fulfillwith a path takes the content type from the upstream table; the stack files of a trace go totracesDir.Long,Float,Throwableand primitive arrays serialize as evaluate arguments (byte[]asInt8Array).maxRedirects, a missing upload file and an unsupported argument; fourjava:fixmes are dropped.