Repository navigation
fix(typescript-vfs): avoid storing duplicate SourceFiles in language service host - #3713
Open
Umut (saiv0n) wants to merge 1 commit into
Open
Umut (saiv0n) wants to merge 1 commit into
Umut (saiv0n) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createVirtualLanguageServiceHostpreviously delegatedupdateFile/deleteFileto an internalcreateVirtualCompilerHost, whosesourceFilesmap was never read by the language service (sincegetScriptSnapshotreads directly fromsys). At the same time,createVirtualTypeScriptEnvironment'screateFile/updateFileparsed throwawaySourceFiles only to pass{ fileName, text }down to that host.This change:
languageServiceHostdirectly on top ofsyswithout allocating an unusedcreateVirtualCompilerHostand itssourceFilesmap.sysincreateVirtualLanguageServiceHost'supdateFile/deleteFile.SourceFiles increateVirtualTypeScriptEnvironment'screateFile/updateFile.createFileandupdateFileupdate the language service without invokingts.createSourceFile/ts.updateSourceFileoutside it.Fixes #3614