Skip to content

Fix remaining Component Governance alerts - #3712

Merged
Jake Bailey (jakebailey) merged 19 commits into
microsoft:v2from
jakebailey:cg-alert-fixes
Nov 20, 2026
Merged

Jake Bailey (jakebailey) merged 19 commits into
microsoft:v2from
jakebailey:cg-alert-fixes

Conversation

@jakebailey

Copy link
Copy Markdown
Member

Fixes the remaining pnpm audit and most Component Governance alerts after #3711.

  • Point lockfile entries back at npmjs; Relock dependencies to satisfy the package feed cooldown #3711 recorded private feed URLs and sha1 hashes.
  • Override vulnerable transitive deps to fixed versions, with small patches where the fix is ESM-only.
  • Drop Parcel's unused dev server reporter.
  • Stop polyfilling crypto in the site, which removes elliptic.
  • Remove ESLint entirely; nothing here uses it, and it was breaking gatsby develop.

Resolving through the package feed proxy recorded feed tarball URLs
and sha1 hashes for the packages it re-resolved. Those URLs point at a
private feed that public installs cannot reach, and sha1 is weaker
than the sha512 integrity npm publishes. Point those entries back at
the public registry with the npm sha512 hashes, which match the
tarballs the feed serves.
cookie before 0.7.0 accepts out-of-bounds characters in cookie names,
paths and domains (GHSA-pxg6-pf52-xh8x). The 0.7 line keeps the same
API, so older dependents can use it unchanged.
tmp before 0.2.6 lets a crafted prefix or postfix escape the temp
directory (GHSA-ph9p-34f9-6g65), and versions up to 0.2.3 follow
symlinks in the dir option (GHSA-52f5-9888-hmc6). Its dependents here
only create files under the default temp directory, which works the
same on 0.2.
serialize-javascript before 7.1.3 has a remote code execution bug
through RegExp flags and Date prototypes (GHSA-5c6j-r48x-rmvq), a CPU
exhaustion bug (GHSA-qj8w-gfj5-8c6v) and unescaped script tags
(GHSA-m5mm-p8h7-m29v). The CSS minimizer and Rollup terser plugin
still ask for 5.x and 6.x, but they only call the default export,
which 7.x keeps.
uuid before 11.1.1 skips a bounds check when v3, v5 or v6 write into
a caller-provided buffer (GHSA-w5hq-g745-h8pq). Gatsby asks for 8.x
but only calls v4, which 11.x still exports from its CommonJS build.
gatsby-plugin-sass depends on resolve-url-loader 3, which pins postcss
7. postcss through 8.5.22 has several advisories, including arbitrary
file reads through attacker-controlled source maps
(GHSA-6g55-p6wh-862q, GHSA-r28c-9q8g-f849). postcss 7 will never get
those fixes. The loader's only postcss use is a plugin registered
through postcss.plugin, which postcss 8 still supports.
decode-uri-component through 0.5.0 can take quadratic or exponential
time on crafted input (GHSA-qr28-fpjm-wq7f, GHSA-vcc3-ghjq-m6fr). The
fixed releases are ESM-only with a default export, which Node 24 can
load through require. query-string 6, used by Gatsby's dev 404 page,
calls the module as a function, so patch it to take the default
export.
file-type before 21.3.1 can loop forever on a malformed ASF file
(GHSA-5v7r-6r5c-r473). The fixed releases are ESM-only, which Node 24
can load through require, and rename fromFile to fileTypeFromFile.
Patch gatsby-core-utils, the only dependent, to call the new name.
@graphql-tools/utils through 12.0.0 has a prototype pollution bug in
its object merging helpers (GHSA-7mx3-vvmw-hjmv). Gatsby's GraphQL
typegen pulls in graphql-codegen 2 and 3, which pin 8.x and 9.x, and
those codegen releases will never move off the vulnerable lines.
webpack-dev-middleware before 7.4.5 can serve files outside the
output directory when the public path lacks a trailing slash
(GHSA-g84c-rxfj-3j2c). gatsby develop still asks for 5.x, but the
options it passes and the watcher it reads are unchanged in 7.x.
glob from 9.0.0 through 14.0.1 keeps walking the file system after
its AbortSignal fires (GHSA-3g3m-2fjr-6pw4). Jest 30 and test-exclude
still ask for 10.x and 13.x, but the glob and glob.sync calls they
make work the same in 14.x.
minimatch from 7.0.0 up to 11.0.1 can blow up on patterns with many
brace and globstar parts (GHSA-g3hv-75wg-m249). test-exclude, which
Jest uses for coverage, is the last dependent on 10.x, and it only
calls the minimatch function itself.
@parcel/reporter-dev-server through 2.16.3 does not validate request
origins (GHSA-qm9p-f9j5-w83w), and the fix only exists alongside
Parcel 2.16, while Gatsby pins Parcel 2.8. Gatsby only runs one-off
Parcel builds to compile its config files, so the dev server reporter
never starts. Remove it from Gatsby's Parcel config and from the
install.
The crypto polyfill pulls in elliptic, which has a risky ECDSA
implementation (GHSA-848j-6mx2-7j84) and no fixed release. Nothing in
the site imports crypto, so the polyfill never reaches the bundle.
Turn off the crypto fallback and remove crypto-browserify from the
install. node-stdlib-browser resolves every polyfill when it loads,
so patch it to skip crypto.
Gatsby lints the site during `gatsby develop` with its bundled
react-app ESLint 7 config. Nothing in this repo asks for that, and the
pnpm peer resolution pairs eslint-plugin-flowtype 5 with ESLint 8 from
dts-cli, which breaks `gatsby develop` outright.

Patch the lint plugin out of Gatsby's develop webpack config and drop
Gatsby's ESLint packages with overrides. The @types/eslint pin and the
site's eslintIgnore only existed for this linting.
dts-cli bundles ESLint 8 and a react-app plugin set for `dts lint`. The
ts-twoslasher and typescript-vfs lint scripts were the only users, and
nothing runs them. These extra ESLint copies also feed pnpm's peer
resolution for Gatsby's lint plugins.

Patch the lint command out of dts-cli, drop its ESLint packages with
overrides, and remove the unused lint scripts.
Gatsby only uses react-dev-utils for formatWebpackMessages and
launchEditor. fork-ts-checker-webpack-plugin is only loaded by an
unused react-dev-utils entry point, and its optional ESLint peer kept
ESLint 8 installed.
No published package needs a release for these dependency changes.
@jakebailey

Copy link
Copy Markdown
Member Author

ugh changesets again

keyv before 5.5.3 lets keys escape their namespace when the namespace
contains a colon (MVS-2026-h644-p4w8), and the 4.x line has no fixed
release. cacheable-request only builds a Keyv instance when got is
given a cache, which nothing here does, so the newer major is safe to
substitute.
@jakebailey
Jake Bailey (jakebailey) merged commit 21bff16 into microsoft:v2 Nov 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants