Repository navigation
Conversation
Gerrit91
reviewed
Nov 19, 2026
| adminCmd.AddCommand(newPartitionCmd(c)) | ||
| adminCmd.AddCommand(newProjectCmd(c)) | ||
| adminCmd.AddCommand(newSizeCmd(c)) | ||
| adminCmd.AddCommand(newSizeReservationCmd(c)) |
Contributor
There was a problem hiding this comment.
Maybe we should make this command a child of size?
Comment on lines
+85
to
+86
| // the admin api does not offer a dedicated get call for size reservations, | ||
| // so we filter the list by the given id. |
Contributor
There was a problem hiding this comment.
The question is why... in the repository the get function is implemented. 😅
Contributor
There was a problem hiding this comment.
Wait... I think I found a get in the normal API and not the Admin API?
Comment on lines
+245
to
+252
| func amountFromCLI() *int32 { | ||
| amount := viper.GetInt32("amount") | ||
| if amount <= 0 { | ||
| return nil | ||
| } | ||
|
|
||
| return new(amount) | ||
| } |
Contributor
There was a problem hiding this comment.
pointer.PointerOrNil should be cleaner than ignoring this flag silently.
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| // AdminSizeReservation lists all size reservations across projects, used for admin completions. |
| "project": func(a, b *apiv2.SizeReservation, descending bool) multisort.CompareResult { | ||
| return multisort.Compare(a.Project, b.Project, descending) | ||
| }, | ||
| "size": func(a, b *apiv2.SizeReservation, descending bool) multisort.CompareResult { |
Contributor
There was a problem hiding this comment.
Filter by amount might be interesting?
Gerrit91
previously approved these changes
Nov 20, 2026
Gerrit91
dismissed
their stale review
November 20, 2026 12:16
I wanted to add the Size Reservation Get to API, but there is one in the non-admin API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Size Reservations where missing
Used AI-Tools ✨