Skip to content

Refactor e2e tests to enable request validation - #74

Merged
Gerrit91 merged 4 commits into
mainfrom
enable-validation-in-e2e-tests
Nov 5, 2026
Merged

Gerrit91 merged 4 commits into
mainfrom
enable-validation-in-e2e-tests

Conversation

@simcod

@simcod simcod commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Description

In the e2e tests the mock interceptor ran before the validation interceptor, so validation was not enforced. This pull request changes this and fixes the validation errors.

Used AI-Tools ✨

  • Sonnet-5.5

@metal-robot metal-robot Bot added this to Development Nov 4, 2026
@simcod
simcod marked this pull request as ready for review November 4, 2026 06:50
@simcod
simcod requested a review from a team as a code owner November 4, 2026 06:50
@simcod
simcod requested a review from Gerrit91 November 4, 2026 06:50

@Gerrit91 Gerrit91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes a lot of sense! Just one question.

Comment thread tests/e2e/admin/network_test.go Resolved
@simcod
simcod requested a review from Gerrit91 November 4, 2026 14:50

@Gerrit91 Gerrit91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gerrit91
Gerrit91 merged commit 0493439 into main Nov 5, 2026
13 checks passed
@Gerrit91
Gerrit91 deleted the enable-validation-in-e2e-tests branch November 5, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants