Repository navigation
feat(compat.harfbuzz): switch no-freetype for 14.3.0 (revision 2) - #860
Merged
Merged
Conversation
A feature, off by default, so the default build is the one it was. The backend's HAVE_* defines move from cxxflags into a generated config.h, read under HAVE_CONFIG_H (hb-config.hh still supplies every other default), and the switch leaves them out (MCPP_FEATURE_NO_FREETYPE is defined for the package's own units). Why: with HAVE_FREETYPE, hb_font_create() reaches hb_ft_font_set_funcs through hb_font_set_funcs_using()'s table of backends, so every program that makes a font links all of FreeType (its core and every driver) whether or not it names FreeType. A consumer whose fonts take HarfBuzz's own `ot` functions (the first in that table, the default) turns the switch on and carries none of it; the functions of <hb-ft.h> are then not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feature, off by default (the default build is unchanged):
no-freetypebuilds HarfBuzz without its FreeType backend.With
HAVE_FREETYPE,hb_font_create()reacheshb_ft_font_set_funcsthroughhb_font_set_funcs_using()'s table of backends (hb-font.cc), so every program that makes a font links all of FreeType, its core and every driver, even when it never names FreeType. A consumer whose fonts use HarfBuzz's ownotfunctions (the default, first in that table) can now turn the switch on and carry none of it. With the switch on,<hb-ft.h>'s functions are not defined.The backend's
HAVE_*defines move from cxxflags into a generatedconfig.hread underHAVE_CONFIG_H(a command-line define could not be taken back);hb-config.hhstill supplies every other default. Revision 2 on the three platform rows.